lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Sep 2022 16:11:42 +0100 From: Jon Hunter <jonathanh@...dia.com> To: Krzysztof Wilczyński <kw@...ux.com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Cc: Vidya Sagar <vidyas@...dia.com>, Bjorn Helgaas <helgaas@...nel.org>, jingoohan1@...il.com, gustavo.pimentel@...opsys.com, lpieralisi@...nel.org, robh@...nel.org, bhelgaas@...gle.com, treding@...dia.com, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, kthota@...dia.com, mmaddireddy@...dia.com, sagar.tv@...il.com Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging On 14/09/2022 15:52, Krzysztof Wilczyński wrote: > Hello, > >>> Perhaps it makes sense to make this a dev_dbg() over dev_info(), especially >>> since it appears that this information is of more use to the developer (who >>> most likely has the suitable log level set anyway), and given that there is >>> no way to reliably detect a presence in a slot on some platforms, this >>> might otherwise, add to the other messages that normal users don't pay >>> attention to usually - if this is not to be treated as an error. >>> >> >> No, this is clearly not a debug message. As I quoted above, the link up >> can fail due to an issue with PHY also. In that case, user has to see >> the log to debug/report the issue. > > Apologies! I missed that. Thank you! > >> So, either dev_info() or dev_err(). > > So, there is nothing to do here, then. This stays as dev_err() as per the > change from: > > 14c4ad125cf9 ("PCI: dwc: Log link speed and width if it comes up") I am not sure I agree. There is a similar change here ... commit 4b16a8227907118e011fb396022da671a52b2272 Author: Manikanta Maddireddy <mmaddireddy@...dia.com> Date: Tue Jun 18 23:32:06 2019 +0530 PCI: tegra: Change link retry log level to debug If we have a way to determine if a card/device is connected then dev_err is appropriate, but if not then dev_dbg/info are appropriate IMO. Jon -- nvpublic
Powered by blists - more mailing lists