linux-kernel - Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-9664ec71-ee9f-49ac-8bea-0c36a574f60a@palmer-ri-x1c9>
Date:   Thu, 15 Sep 2022 11:48:10 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     heiko@...ech.de
CC:     linux-kernel@...r.kernel.org, rdunlap@...radead.org,
        rdunlap@...radead.org, wefu@...hat.com, liush@...winnertech.com,
        guoren@...nel.org, Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org
Subject:     Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning

On Tue, 13 Sep 2022 05:00:08 PDT (-0700), heiko@...ech.de wrote:
> Hi Palmer,
>
> Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
>> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
>> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
>> quieten this kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
>>   Depends on [n]: !XIP_KERNEL [=y]
>>   Selected by [y]:
>>   - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>>
>> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>
> I think this should also be applied as fix?

Thanks, the original seems to have gotten lost somewhere but I've picked 
this up from lore.

>
> Thanks
> Heiko
>
>
>> Cc: Wei Fu <wefu@...hat.com>
>> Cc: Liu Shaohua <liush@...winnertech.com>
>> Cc: Guo Ren <guoren@...nel.org>
>> Cc: Heiko Stuebner <heiko@...ech.de>
>> Cc: Paul Walmsley <paul.walmsley@...ive.com>
>> Cc: Palmer Dabbelt <palmer@...belt.com>
>> Cc: Albert Ou <aou@...s.berkeley.edu>
>> Cc: linux-riscv@...ts.infradead.org
>> ---
>>  arch/riscv/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -362,6 +362,7 @@ config RISCV_ISA_C
>>  config RISCV_ISA_SVPBMT
>>  	bool "SVPBMT extension support"
>>  	depends on 64BIT && MMU
>> +	depends on !XIP_KERNEL
>>  	select RISCV_ALTERNATIVE
>>  	default y
>>  	help
>>