linux-kernel - Re: [PATCH V6 0/6] RISC-V fixups to work with crash tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <39fdc85e-b2d5-863c-4878-4b3380d76bc4@microchip.com>
Date:   Thu, 15 Sep 2022 18:57:14 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <xianting.tian@...ux.alibaba.com>, <palmer@...belt.com>
CC:     <paul.walmsley@...ive.com>, <aou@...s.berkeley.edu>,
        <anup@...infault.org>, <heiko@...ech.de>, <guoren@...nel.org>,
        <mick@....forth.gr>, <alexandre.ghiti@...onical.com>,
        <bhe@...hat.com>, <vgoyal@...hat.com>, <dyoung@...hat.com>,
        <corbet@....net>, <kexec@...ts.infradead.org>,
        <linux-doc@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <crash-utility@...hat.com>,
        <heinrich.schuchardt@...onical.com>, <k-hagio-ab@....com>,
        <hschauhan@...ltrace.org>, <yixun.lan@...il.com>
Subject: Re: [PATCH V6 0/6] RISC-V fixups to work with crash tool

On 12/08/2022 04:23, Xianting Tian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> 在 2022/8/12 上午12:17, Palmer Dabbelt 写道:
>> On Thu, 11 Aug 2022 00:41:44 PDT (-0700),
>> xianting.tian@...ux.alibaba.com wrote:
>>> I ever sent the patch 1 in the link:
>>> https://patchwork.kernel.org/project/linux-riscv/patch/20220708073150.352830-3-xianting.tian@linux.alibaba.com/
>>>
>>> And patch 2,3 in the link:
>>> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-2-xianting.tian@linux.alibaba.com/
>>>
>>> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-3-xianting.tian@linux.alibaba.com/
>>>
>>>
>>> This patch set just put these patches together, and with three new
>>> patch 4, 5, 6.
>>> these six patches are the fixups for machine_kexec, kernel mode PC
>>> for vmcore
>>> and improvements for vmcoreinfo, memory layout dump and fixup
>>> schedule out issue
>>> in machine_crash_shutdown().
>>>
>>> The main changes in the six patchs as below,
>>> Patch 1: Fixup use of smp_processor_id() in preemptible context, to
>>> cleanup
>>>          the console prints.
>>> Patch 2: Fixup to get correct kernel mode PC for kernel mode regs for
>>> vmcore.
>>> Patch 3: Fixup schedule out issue in machine_crash_shutdown()
>>> Patch 4: Add modules to virtual kernel memory layout dump.
>>> Patch 5: Add VM layout, va bits, ram base to vmcoreinfo, which can
>>> simplify
>>>          the development of crash tool as ARM64 already did
>>>          (arch/arm64/kernel/crash_core.c).
>>> Patch 6: Updates vmcoreinfo.rst for vmcoreinfo export for RISCV64.
>>>
>>> With these six patches(patch 2 is must), crash tool can work well to
>>> analyze
>>> a vmcore. The patches for crash tool for RISCV64 is in the link:
>>> https://lore.kernel.org/linux-riscv/20220801043040.2003264-1-xianting.tian@linux.alibaba.com/
>>>
>>>
>>> ------
>>> Changes v1 -> v2:
>>>   1, remove the patch "Add a fast call path of crash_kexec()" from
>>> this series
>>>      of patches, as it already applied to riscv git.
>>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98
>>>   2, add 'Reviewed-by' based on the comments of v1.
>>> Changes v2 -> v3:
>>>   use "riscv" instead of "riscv64" in patch 5 subject line.
>>> Changes v3 -> v4:
>>>   use "riscv" instead of "riscv64" in the summary of patch 5 subject
>>> line.
>>> Changes v4 -> v5:
>>>   add a new patch "RISC-V: Fixup schedule out issue in
>>> machine_crash_shutdown()"
>>> Changes v5 -> v6:
>>>   1, move "fixup" patches to the start of the patch set.
>>>   2, change patch 1, 2, 6's subject to make it tell more what it's
>>> about.
>>>   3, add Fixes for patch 3.
>>>   4, adjuest the changes format for patch 6.
>>>
>>>
>>> Xianting Tian (6):
>>>   RISC-V: kexec: Fixup use of smp_processor_id() in preemptible context
>>>   RISC-V: Fixup get incorrect user mode PC for kernel mode regs
>>>   RISC-V: Fixup schedule out issue in machine_crash_shutdown()
>>>   RISC-V: Add modules to virtual kernel memory layout dump
>>>   RISC-V: Add arch_crash_save_vmcoreinfo support
>>>   Documentation: kdump: describe VMCOREINFO export for RISCV64
>>>
>>>  .../admin-guide/kdump/vmcoreinfo.rst          | 31 +++++++++++++++++++
>>>  arch/riscv/kernel/Makefile                    |  1 +
>>>  arch/riscv/kernel/crash_core.c                | 29 +++++++++++++++++
>>>  arch/riscv/kernel/crash_save_regs.S           |  2 +-
>>>  arch/riscv/kernel/machine_kexec.c             | 28 ++++++++++++++---
>>>  arch/riscv/mm/init.c                          |  4 +++
>>>  6 files changed, 89 insertions(+), 6 deletions(-)
>>>  create mode 100644 arch/riscv/kernel/crash_core.c
>>
>> Thank.  I've taken the first 4 onto for-next, which is still targeted
>> for 5.20, as they're fixes.  I'm not opposed to taking the
>> documentation patch for this cycle as well, it just needs some
>> going-over as the wording looks very odd (or at least it does to me
>> right now, maybe I'm just still half asleep).  Patch 5 is a new
>> feature, and given that it's being spun during the merge window it's
>> too late.
> 
> Thank you Palmer, Conor.
> I saw patch 5,6 already merged to Palmer's riscv-crash branch,
> https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git/log/?h=riscv-crash
> Looking forward to be merged to 6.1(?). thanks.
> 

From reading this, it looks like another revision (for the remaining
patches) might be a good idea so that the docs can undergo further
review?

Thanks
Conor.