[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220915195719.136812-1-eajames@linux.ibm.com>
Date: Thu, 15 Sep 2022 14:57:17 -0500
From: Eddie James <eajames@...ux.ibm.com>
To: jic23@...nel.org
Cc: lars@...afoo.de, linux-iio@...r.kernel.org, joel@....id.au,
linux-kernel@...r.kernel.org, andy.shevchenko@...il.com,
stable@...r.kernel.org, eajames@...ux.ibm.com
Subject: [PATCH v8 0/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt
The DPS310 chip has been observed to get "stuck" such that pressure
and temperature measurements are never indicated as "ready" in the
MEAS_CFG register. The only solution is to reset the device and try
again. In order to avoid continual failures, use a boolean flag to
only try the reset after timeout once if errors persist. Include a
patch to move the startup procedure into a function.
Changes since v7:
- Condense the code a bit by dropping rc2
Changes since v6:
- Use helper instead of the lengthy regmap_read_poll_timeout twice
- Just return dps310_startup in dps310_reset_reinit
Changes since v5:
- Completely rework the second patch to reset and reinit in any
timeout condition, if there haven't been previous timeouts that
failed to recover the chip.
Changes since v4:
- Just check for rc rather than rc < 0 in some cases
- Split declaration and init of rc
Changes since v3:
- Don't check regmap* return codes for < 0
- Fix comment spelling
Changes since v2:
- Add some comments
- Fix the clunky control flow
Changes since v1:
- Separate into two patches
- Rename 'dps310_verify_meas_cfg' to 'dps310_check_reset_meas_cfg'
Eddie James (2):
iio: pressure: dps310: Refactor startup procedure
iio: pressure: dps310: Reset chip after timeout
drivers/iio/pressure/dps310.c | 262 +++++++++++++++++++++-------------
1 file changed, 163 insertions(+), 99 deletions(-)
--
2.31.1
Powered by blists - more mailing lists