[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAK7LNARfQodG3tSYBs7ZAzsbkdwDS0=g=e8qJStfBi3BGut7Fw@mail.gmail.com>
Date: Thu, 15 Sep 2022 13:37:02 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Florian Eckert <fe@....tdt.de>
Cc: Michal Marek <michal.lkml@...kovi.net>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
Eckert.Florian@...glemail.com
Subject: Re: [PATCH] fs/proc: add compile time info
On Mon, Sep 12, 2022 at 6:42 PM Florian Eckert <fe@....tdt.de> wrote:
>
> Hello Masahiro,
>
> thanks for your feedback.
>
> > https://patchwork.kernel.org/project/linux-kbuild/patch/20220828024003.28873-6-masahiroy@kernel.org/
> > lands, nobody cannot reference KBUILD_BUILD_TIMESTAMP,
> > then this whack-a-mole game will end.
>
> I was not aware of that problem. Thanks for the link.
>
> I understood that this is a bad idea to create the timestamp for proc
> like this!
> But how does it look in principle to offer the build timestamp in proc
> for reading?
> You have only made your point about creating the timestamp but not about
> reading it out via the proc directory.
>
> So far the timestamp is only readable as a string via dmesg.
init/version.c is the only file that can depend on the output of
the 'date' command.
You can follow what 'linux_proc_banner' does.
Define it in init/version.c, and declare it somewhere in a header file.
> Best regards
>
> Florian
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists