linux-kernel - Re: [PATCH] parisc: remove obsolete manual allocation aligning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76919d92-0a85-8c83-c434-ba8998d19a07@gmx.de>
Date:   Thu, 15 Sep 2022 07:34:48 +0200
From:   Helge Deller <deller@....de>
To:     Rolf Eike Beer <eike-kernel@...tec.de>,
        linux-parisc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: remove obsolete manual allocation aligning

On 9/14/22 16:23, Rolf Eike Beer wrote:
> kmalloc() returns memory with __assume_kmalloc_alignment, which is
> __alignof__(unsigned long long) for parisc.
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@...tec.de>

applied.

Thanks!
Helge


> ---
>   drivers/parisc/iosapic.c | 11 +----------
>   1 file changed, 1 insertion(+), 10 deletions(-)
>
> I must confirm it's entirely untested.
>
> diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
> index 3a8c98615634..bdef7a8d6ab8 100644
> --- a/drivers/parisc/iosapic.c
> +++ b/drivers/parisc/iosapic.c
> @@ -221,16 +221,7 @@ static size_t irt_num_entry;
>
>   static struct irt_entry *iosapic_alloc_irt(int num_entries)
>   {
> -	unsigned long a;
> -
> -	/* The IRT needs to be 8-byte aligned for the PDC call.
> -	 * Normally kmalloc would guarantee larger alignment, but
> -	 * if CONFIG_DEBUG_SLAB is enabled, then we can get only
> -	 * 4-byte alignment on 32-bit kernels
> -	 */
> -	a = (unsigned long)kmalloc(sizeof(struct irt_entry) * num_entries + 8, GFP_KERNEL);
> -	a = (a + 7UL) & ~7UL;
> -	return (struct irt_entry *)a;
> +	return kcalloc(num_entries, sizeof(struct irt_entry), GFP_KERNEL);
>   }
>
>   /**