linux-kernel - Re: [PATCH -next] net: fs_enet: Fix wrong check in do_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c84e673c-3542-c5e5-3779-17312779871d@csgroup.eu>
Date:   Thu, 15 Sep 2022 06:27:10 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        "pantelis.antoniou@...il.com" <pantelis.antoniou@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "zhengbin13@...wei.com" <zhengbin13@...wei.com>
Subject: Re: [PATCH -next] net: fs_enet: Fix wrong check in do_pd_setup



Le 08/09/2022 à 15:55, Zheng Yongjun a écrit :
> [Vous ne recevez pas souvent de courriers de zhengyongjun3@...wei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> Should check of_iomap return value 'fep->fec.fecp' instead of 'fep->fcc.fccp'
> 
> Fixes: 976de6a8c304 ("fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   drivers/net/ethernet/freescale/fs_enet/mac-fec.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> index 99fe2c210d0f..61f4b6e50d29 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> @@ -98,7 +98,7 @@ static int do_pd_setup(struct fs_enet_private *fep)
>                  return -EINVAL;
> 
>          fep->fec.fecp = of_iomap(ofdev->dev.of_node, 0);
> -       if (!fep->fcc.fccp)
> +       if (!fep->fec.fecp)
>                  return -EINVAL;
> 
>          return 0;
> --
> 2.17.1
>