linux-kernel - Re: [PATCH -next 4/5] selftests/memory-hotplug: Restore memory before exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a87ac52f279b4bc3944c57f135d8c03c@huawei.com>
Date:   Thu, 15 Sep 2022 09:07:13 +0000
From:   zhaogongyi <zhaogongyi@...wei.com>
To:     David Hildenbrand <david@...hat.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
CC:     "akinobu.mita@...il.com" <akinobu.mita@...il.com>,
        "corbet@....net" <corbet@....net>,
        "osalvador@...e.de" <osalvador@...e.de>,
        "shuah@...nel.org" <shuah@...nel.org>
Subject: Re: [PATCH -next 4/5] selftests/memory-hotplug: Restore memory before
 exit

Hi,

Thanks for your review, I have submit the patches in a new version as your suggestion.

Best Wishes,
Gongyi

> 
> On 09.09.22 09:51, Zhao Gongyi wrote:
> > Some momory will be left in offline state when calling
> > offline_memory_expect_fail() failed. Restore it before exit.
> >
> > Signed-off-by: Zhao Gongyi <zhaogongyi@...wei.com>
> > ---
> >   .../memory-hotplug/mem-on-off-test.sh         | 24
> +++++++++++++------
> >   1 file changed, 17 insertions(+), 7 deletions(-)
> >
> > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> > b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> > index 3bdf3c4d6d06..259fd8978639 100755
> > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> > @@ -134,6 +134,17 @@ offline_memory_expect_fail()
> >   	return 0
> >   }
> >
> > +online_all_hot_pluggable_memory()
> > +{
> > +
> > +	for memory in `hotpluggable_offline_memory`; do
> > +		online_memory_expect_success $memory || {
> > +			echo "online memory $memory: unexpected fail"
> > +			retval=1
> > +		}
> > +	done
> > +}
> 
> Maybe call it
> 
> "online_all_offline_memory()"
> 
> instead?
> 
> Note that "removable" as used in hotpluggable_memory() will nowadays
> always return "1" if the kernel supports memory hotunplug, independent
> of the specific memory block.
> 
> --
> Thanks,
> 
> David / dhildenb