linux-kernel - Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2d81ffd-2269-bdc6-0daa-8f3a99306e46@amd.com>
Date:   Thu, 15 Sep 2022 14:07:49 +0200
From:   Christian König <christian.koenig@....com>
To:     Arvind Yadav <Arvind.Yadav@....com>, andrey.grodzovsky@....com,
        shashank.sharma@....com, amaranath.somalapuram@....com,
        Arunpravin.PaneerSelvam@....com, sumit.semwal@...aro.org,
        gustavo@...ovan.org, airlied@...ux.ie, daniel@...ll.ch,
        linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on
 debug

Is that sufficient to allow running a desktop on amdgpu with the extra 
check enabled? If yes that would be quite a milestone.

What's left is checking the userspace IGT tests. Especially the 
sync_file and drm_syncobj tests I would expect to have problems with 
this extra check.

Thanks,
Christian.

Am 14.09.22 um 18:43 schrieb Arvind Yadav:
> Fence signaling must be enabled to make sure that
> the dma_fence_is_signaled() function ever returns true.
> Since drivers and implementations sometimes mess this up,
> this ensures correct behaviour when DEBUG_WW_MUTEX_SLOWPATH
> is used during debugging.
> This should make any implementation bugs resulting in not
> signaled fences much more obvious.
>
> Arvind Yadav (6):
>    [PATCH v4 1/6] dma-buf: Remove the signaled bit status check
>    [PATCH v4 2/6] dma-buf: set signaling bit for the stub fence
>    [PATCH v4 3/6] dma-buf: Enable signaling on fence for selftests
>    [PATCH v4 4/6] dma-buf: dma_fence_wait must enable signaling
>    [PATCH v4 5/6] drm/sched: Use parent fence instead of finished
>    [PATCH v4 6/6] dma-buf: Check status of enable-signaling bit on debug
>
>   drivers/dma-buf/Kconfig                |  7 +++++++
>   drivers/dma-buf/dma-fence.c            | 16 ++++++++++------
>   drivers/dma-buf/st-dma-fence-chain.c   |  4 ++++
>   drivers/dma-buf/st-dma-fence-unwrap.c  | 22 ++++++++++++++++++++++
>   drivers/dma-buf/st-dma-fence.c         | 16 ++++++++++++++++
>   drivers/dma-buf/st-dma-resv.c          | 10 ++++++++++
>   drivers/gpu/drm/scheduler/sched_main.c |  4 ++--
>   include/linux/dma-fence.h              |  5 +++++
>   8 files changed, 76 insertions(+), 8 deletions(-)
>