linux-kernel - Re: [PATCH v2] iio: pressure: bmp280: fix datasheet links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b8736f0cc3c68bbec52aab503aeaec74e60ae87.camel@gmail.com>
Date:   Thu, 15 Sep 2022 16:59:54 +0200
From:   Angel Iglesias <ang.iglesiasg@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Paul Cercueil <paul@...pouillou.net>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: pressure: bmp280: fix datasheet links

On jue, 2022-09-15 at 14:39 +0100, Jonathan Cameron wrote:
> On Tue, 13 Sep 2022 00:26:44 +0200
> Angel Iglesias <ang.iglesiasg@...il.com> wrote:
> 
> > Updated links for BMP280 and BME280 datasheets on Bosch website.
> > Datasheet of BMP180 is no longer available on the manufacturer's website,
> > changed the link to a copy hosted by a third party.
> > 
> > Changelog in v2:
> > * Added a notice about the situation with bmp180 datasheet and list
> >   missing changes from newer versions.
> Change log needs to be below the ---
> 
> We don't want that level of detail in the git logs.
> 
> I tidied that up whilst applying. 
> 
> Also, it's not a good idea to have new versions as replies
> to older ones.  Leads to very deep nesting in email threads
> and generally makes things less readable.  Just post
> a fresh series each time.
> 
> Applied to the togreg branch of iio.git and pushed out as testing 
> for 0-day to see if it can find anything (rather unlikely on this
> patch!)
> 
> Jonathan
> 

OK, I'll keep it on my mind for future contributions. Thanks for your help and
patience!

Kind regards,
Angel

> 
> > 
> > Reported-by: Andy Shevchenko <andy.shevchenko@...il.com>
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@...il.com>
> > ---
> >  drivers/iio/pressure/bmp280-core.c | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/pressure/bmp280-core.c
> > b/drivers/iio/pressure/bmp280-core.c
> > index fe7aa81e7cc9..01cd32003ca8 100644
> > --- a/drivers/iio/pressure/bmp280-core.c
> > +++ b/drivers/iio/pressure/bmp280-core.c
> > @@ -9,9 +9,15 @@
> >   * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
> >   *
> >   * Datasheet:
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> > + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
> > + *
> > + * Notice:
> > + * The link to the bmp180 datasheet points to an outdated version missing
> > these changes:
> > + * - Changed document referral from ANP015 to BST-MPS-AN004-00 on page 26
> > + * - Updated equation for B3 param on section 3.5 to ((((long)AC1 * 4 + X3)
> > << oss) + 2) / 4
> > + * - Updated RoHS directive to 2011/65/EU effective 8 June 2011 on page 26
> >   */
> >  
> >  #define pr_fmt(fmt) "bmp280: " fmt
> > 
> > base-commit: 2f61ff8272967c9bdcba810aa978170814b08f7c
>