linux-kernel - Re: [PATCH bpf-next] bpf/btf: Use btf_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c01a2b8-bfb7-df72-faae-0b940ea0f149@linux.dev>
Date:   Fri, 16 Sep 2022 11:37:46 -0700
From:   Martin KaFai Lau <martin.lau@...ux.dev>
To:     Peilin Ye <yepeilin.cs@...il.com>
Cc:     Peilin Ye <peilin.ye@...edance.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf/btf: Use btf_type_str() whenever possible

On 9/13/22 7:13 PM, Peilin Ye wrote:
> From: Peilin Ye <peilin.ye@...edance.com>
> 
> We have btf_type_str().  Use it whenever possible in btf.c, instead of
> "btf_kind_str[BTF_INFO_KIND(t->info)]".
> 
> Signed-off-by: Peilin Ye <peilin.ye@...edance.com>
> ---
>   kernel/bpf/btf.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index cad4657ba2ce..81dc7423d723 100644

This clean up makes sense.  The patch cannot be applied though [0], so 
it is marked as 'Changes Requested'.  Also, where is the cad4657ba2ce 
coming from?  It can't be found in the bpf-next tree.  Please rebase on 
the bpf-next and resend.


[0]: 
https://patchwork.kernel.org/project/netdevbpf/patch/20220914021328.17039-1-yepeilin.cs@gmail.com/