linux-kernel - Re: [PATCH] i2c: mux: harden i2c_mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyTPLkOfPlgkLaxq@shikoro>
Date:   Fri, 16 Sep 2022 20:31:58 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Kees Cook <keescook@...omium.org>, Peter Rosin <peda@...ntia.se>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] i2c: mux: harden i2c_mux_alloc() against integer
 overflows


> > The new variable makes it more readable, but beyond that, do you see any
> > reason not to just directly compose the calls?
> > 
> 
> You could do that too.
> 
> You pointed this out in your other email but the one thing that people
> have to be careful of when assigning struct_size() is that the
> "mux_size" variable has to be size_t.
> 
> The math in submit_create() from drivers/gpu/drm/msm/msm_gem_submit.c
> is so terribly unreadable.  It works but it's so ugly.  Unfortunately,
> I'm the person who wrote it.

I can't parse from that if the patch in question is okay or needs a
respin? Could you kindly enlighten me?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)