linux-kernel - Re: [PATCH] liquidio: CN23XX: delete repeated words

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <293d8d5b-8423-a8bc-a42f-34b08ee65717@infradead.org>
Date:   Thu, 15 Sep 2022 21:17:00 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ruffalo Lavoisier <ruffalolavoisier@...il.com>,
        Derek Chickles <dchickles@...vell.com>,
        Satanand Burla <sburla@...vell.com>,
        Felix Manlunas <fmanlunas@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] liquidio: CN23XX: delete repeated words

Hi--

There are several other problems here also.
Preferably fix all of them.

On 9/15/22 01:46, Ruffalo Lavoisier wrote:
> - Delete the repeated word 'to' in the comment
> 
> Signed-off-by: Ruffalo Lavoisier <RuffaloLavoisier@...il.com>
> ---
>   drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h | 2 +-
>   drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
> index 3f1c189646f4..9a994b5bfff5 100644
> --- a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
> +++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h
> @@ -88,7 +88,7 @@
>   #define    CN23XX_SLI_PKT_IN_JABBER                0x29170
>   /* The input jabber is used to determine the TSO max size.
>    * Due to H/W limitation, this need to be reduced to 60000

                               this needs

> - * in order to to H/W TSO and avoid the WQE malfarmation > + * in order to H/W TSO and avoid the WQE malfarmation

Now it is missing some word. Something like
       in order to use H/W TSO
makes some sense.

Also, s/malfarmation/malformation/

>    * PKO_BUG_24989_WQE_LEN
>    */
>   #define    CN23XX_DEFAULT_INPUT_JABBER             0xEA60 /*60000*/
> diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
> index d33dd8f4226f..19894b7c1ce8 100644
> --- a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
> +++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h
> @@ -37,7 +37,7 @@
>   
>   /* The input jabber is used to determine the TSO max size.
>    * Due to H/W limitation, this need to be reduced to 60000
> - * in order to to H/W TSO and avoid the WQE malfarmation
> + * in order to H/W TSO and avoid the WQE malfarmation

Same as comments above.

>    * PKO_BUG_24989_WQE_LEN
>    */
>   #define    CN23XX_DEFAULT_INPUT_JABBER             0xEA60 /*60000*/