linux-kernel - Re: [RFC v1 net-next 2/8] net: mscc: ocelot: expose regfield definition to be used by other drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220916223600.aokvipptiwdheand@skbuf>
Date:   Fri, 16 Sep 2022 22:36:00 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Colin Foster <colin.foster@...advantage.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Russell King <linux@...linux.org.uk>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Lee Jones <lee@...nel.org>
Subject: Re: [RFC v1 net-next 2/8] net: mscc: ocelot: expose regfield
 definition to be used by other drivers

On Fri, Sep 16, 2022 at 10:44:56AM -0700, Colin Foster wrote:
> I'm assuming you'll agree with my a-ha moment regarding ocelot_reset()
> being in the ocelot_lib.
> 
> There might be a few others as well. Should I add them as more "export
> function X" commits, or squash them (and these already-reviewed commits)
> in a larger "export a bunch of resources and symbols" type commit to
> keep the patch count low?

Try to keep patches doing one thing and one thing well (and leave this
patch alone).