linux-kernel - drivers/irqchip/irq-loongson-pch-lpc.c:151:13: warning: declaration of 'struct acpi_madt_lpc_pic' will not be visible outside of this function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 16 Sep 2022 13:59:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Huacai Chen <chenhuacai@...ngson.cn>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Marc Zyngier <maz@...nel.org>,
        Jianmin Lv <lvjianmin@...ngson.cn>
Subject: drivers/irqchip/irq-loongson-pch-lpc.c:151:13: warning: declaration
 of 'struct acpi_madt_lpc_pic' will not be visible outside of this function

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3245cb65fd91cd514801bf91f5a3066d562f0ac4
commit: ee73f14ee9eb7e1a04051b303b56130c4dd6e048 irqchip: Add Loongson PCH LPC controller support
date:   8 weeks ago
config: mips-randconfig-r023-20220915 (https://download.01.org/0day-ci/archive/20220916/202209161317.b47Av73d-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips64el-linux-gnuabi64
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ee73f14ee9eb7e1a04051b303b56130c4dd6e048
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout ee73f14ee9eb7e1a04051b303b56130c4dd6e048
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/irqchip/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/irqchip/irq-loongson-pch-lpc.c:151:13: warning: declaration of 'struct acpi_madt_lpc_pic' will not be visible outside of this function [-Wvisibility]
                                           struct acpi_madt_lpc_pic *acpi_pchlpc)
                                                  ^
   drivers/irqchip/irq-loongson-pch-lpc.c:164:34: error: incomplete definition of type 'struct acpi_madt_lpc_pic'
           priv->base = ioremap(acpi_pchlpc->address, acpi_pchlpc->size);
                                ~~~~~~~~~~~^
   arch/mips/include/asm/io.h:180:16: note: expanded from macro 'ioremap'
           ioremap_prot((offset), (size), _CACHE_UNCACHED)
                         ^~~~~~
   drivers/irqchip/irq-loongson-pch-lpc.c:151:13: note: forward declaration of 'struct acpi_madt_lpc_pic'
                                           struct acpi_madt_lpc_pic *acpi_pchlpc)
                                                  ^
   drivers/irqchip/irq-loongson-pch-lpc.c:164:56: error: incomplete definition of type 'struct acpi_madt_lpc_pic'
           priv->base = ioremap(acpi_pchlpc->address, acpi_pchlpc->size);
                                                      ~~~~~~~~~~~^
   arch/mips/include/asm/io.h:180:26: note: expanded from macro 'ioremap'
           ioremap_prot((offset), (size), _CACHE_UNCACHED)
                                   ^~~~
   drivers/irqchip/irq-loongson-pch-lpc.c:151:13: note: forward declaration of 'struct acpi_madt_lpc_pic'
                                           struct acpi_madt_lpc_pic *acpi_pchlpc)
                                                  ^
   drivers/irqchip/irq-loongson-pch-lpc.c:188:31: error: incomplete definition of type 'struct acpi_madt_lpc_pic'
           fwspec.param[0] = acpi_pchlpc->cascade + GSI_MIN_PCH_IRQ;
                             ~~~~~~~~~~~^
   drivers/irqchip/irq-loongson-pch-lpc.c:151:13: note: forward declaration of 'struct acpi_madt_lpc_pic'
                                           struct acpi_madt_lpc_pic *acpi_pchlpc)
                                                  ^
   drivers/irqchip/irq-loongson-pch-lpc.c:188:43: error: use of undeclared identifier 'GSI_MIN_PCH_IRQ'
           fwspec.param[0] = acpi_pchlpc->cascade + GSI_MIN_PCH_IRQ;
                                                    ^
>> drivers/irqchip/irq-loongson-pch-lpc.c:150:12: warning: no previous prototype for function 'pch_lpc_acpi_init' [-Wmissing-prototypes]
   int __init pch_lpc_acpi_init(struct irq_domain *parent,
              ^
   drivers/irqchip/irq-loongson-pch-lpc.c:150:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __init pch_lpc_acpi_init(struct irq_domain *parent,
   ^
   static 
   2 warnings and 4 errors generated.


vim +151 drivers/irqchip/irq-loongson-pch-lpc.c

   149	
 > 150	int __init pch_lpc_acpi_init(struct irq_domain *parent,
 > 151						struct acpi_madt_lpc_pic *acpi_pchlpc)

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp