[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yq15yho3y0s.fsf@ca-mkp.ca.oracle.com>
Date: Thu, 15 Sep 2022 21:32:59 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Arun Easi <aeasi@...vell.com>,
Martin Petersen <martin.petersen@...cle.com>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
James Bottomley <jejb@...ux.ibm.com>,
<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-next@...r.kernel.org>,
<GR-QLogic-Storage-Upstream@...vell.com>
Subject: Re: [PATCH v3 1/1] tracing: Fix compile error in trace_array calls
when TRACING is disabled
Steven,
Can you please review Arun's patch?
> Fix this compilation error seen when CONFIG_TRACING is not enabled:
>
> drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init':
> drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function
> 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'?
> [-Werror=implicit-function-declaration]
> 2854 | qla_trc_array = trace_array_get_by_name("qla2xxx");
> | ^~~~~~~~~~~~~~~~~~~~~~~
> | trace_array_set_clr_event
>
> drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit':
> drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function
> 'trace_array_put' [-Werror=implicit-function-declaration]
> 2869 | trace_array_put(qla_trc_array);
> | ^~~~~~~~~~~~~~~
>
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists