linux-kernel - Re: [PATCH 1/2] drm/omap: dsi: Fix excessive stack usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8202c089-e6dd-4027-a838-f08971b155ce@www.fastmail.com>
Date:   Fri, 16 Sep 2022 10:23:28 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Tomi Valkeinen" <tomi.valkeinen@...asonboard.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Linux-OMAP <linux-omap@...r.kernel.org>
Cc:     "Linus Walleij" <linus.walleij@...aro.org>,
        "kernel test robot" <lkp@...el.com>
Subject: Re: [PATCH 1/2] drm/omap: dsi: Fix excessive stack usage

On Fri, Sep 16, 2022, at 10:22 AM, Tomi Valkeinen wrote:
> dsi_dump_dsi_irqs(), a function used for debugfs prints, has a large
> struct in its frame, which can result in:
>
> drivers/gpu/drm/omapdrm/dss/dsi.c:1126:1: warning: the frame size of 
> 1060 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>
> As the performance of the function is of no concern, let's allocate the
> struct with kmalloc instead.
>
> Compile-tested only.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> Reported-by: kernel test robot <lkp@...el.com>

Looks good to me,

Reviewed-by: Arnd Bergmann <arnd@...db.de>