linux-kernel - Re: [PATCH] xen/privcmd: remove privcmd_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2209151709420.157835@ubuntu-linux-20-04-desktop>
Date:   Thu, 15 Sep 2022 17:11:16 -0700 (PDT)
From:   Stefano Stabellini <sstabellini@...nel.org>
To:     Jan Beulich <jbeulich@...e.com>
cc:     Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen/privcmd: remove privcmd_ioctl_mmap()

On Thu, 15 Sep 2022, Jan Beulich wrote:
> On 15.09.2022 12:20, Juergen Gross wrote:
> > On 15.09.22 11:32, Jan Beulich wrote:
> >> On 15.09.2022 10:39, Juergen Gross wrote:
> >>> The IOCTL_PRIVCMD_MMAP isn't in use by Xen since at least Xen 4.0.
> >>>
> >>> Remove it from the privcmd driver.
> >>>
> >>> Signed-off-by: Juergen Gross <jgross@...e.com>
> >>
> >> Can we reasonably remove an IOCTL, without being entirely certain that
> >> no users exist outside of xen.git?
> > 
> > This is a valid question. I'm not sure how probable it is that such a user
> > is existing. Are there any Xen tool stacks not using the Xen libraries?
> > 
> > If so, why? Do we want to support those use cases?
> 
> I'm afraid I have no answers to these questions, and hence would generally
> want to be conservative with removal of functionality.

I don't know either, but maybe we could at least mark IOCTL_PRIVCMD_MMAP
as deprecated in include/uapi/xen/privcmd.h ?