linux-kernel - Re: [PATCH] Input: i8042 - Add PNP checking hook for Loongson

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e5433179-c300-482e-9dad-b1b15c56970a@www.fastmail.com>
Date:   Fri, 16 Sep 2022 12:16:25 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Huacai Chen" <chenhuacai@...nel.org>,
        "Huacai Chen" <chenhuacai@...ngson.cn>
Cc:     "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        loongarch@...ts.linux.dev, Linux-Arch <linux-arch@...r.kernel.org>,
        "Xuefeng Li" <lixuefeng@...ngson.cn>, guoren <guoren@...nel.org>,
        "WANG Xuerui" <kernel@...0n.name>,
        "Jiaxun Yang" <jiaxun.yang@...goat.com>,
        linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        "Jianmin Lv" <lvjianmin@...ngson.cn>
Subject: Re: [PATCH] Input: i8042 - Add PNP checking hook for Loongson

On Fri, Sep 16, 2022, at 11:53 AM, Huacai Chen wrote:
> Ping?
>
> On Thu, Aug 18, 2022 at 12:04 PM Huacai Chen <chenhuacai@...ngson.cn> wrote:
>>
>> Add PNP checking related functions for Loongson, so that i8042 driver
>> can work well under the ACPI firmware with PNP typed keyboard and mouse
>> configured in DSDT.
>>
>> Signed-off-by: Jianmin Lv <lvjianmin@...ngson.cn>
>> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
>> ---
>>  drivers/input/serio/i8042-loongsonio.h | 330 +++++++++++++++++++++++++
>>  drivers/input/serio/i8042.h            |   2 +
>>  2 files changed, 332 insertions(+)

This looks like you are just duplicating code from
i8042-x86ia64io.h. Can't you just use that version
directly?

      Arnd