linux-kernel - Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220916101738.xn7xx7ipf7p5dbok@fsr-ub1664-116>
Date:   Fri, 16 Sep 2022 13:17:38 +0300
From:   Viorel Suman <viorel.suman@....nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Abel Vesa <abelvesa@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Viorel Suman <viorel.suman@....com>, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit
 v1.13.0

On 22-09-16 10:38:30, Krzysztof Kozlowski wrote:
> On 15/09/2022 19:18, Viorel Suman (OSS) wrote:
> > From: Viorel Suman <viorel.suman@....com>
> > 
> > Sync defines with the latest available SCFW kit version 1.13.0,
> > may be found at the address below:
> > 
> > https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license
> > 
> > Signed-off-by: Viorel Suman <viorel.suman@....com>
> > ---
> >  include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++--------
> >  1 file changed, 203 insertions(+), 96 deletions(-)
> > 
> > diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h
> > index 43885056557c..a4c68f394986 100644
> > --- a/include/dt-bindings/firmware/imx/rsrc.h
> > +++ b/include/dt-bindings/firmware/imx/rsrc.h
> > @@ -13,34 +13,38 @@
> >   * never be changed or removed (only added to at the end of the list).
> >   */
> >  
> > -#define IMX_SC_R_A53			0
> > -#define IMX_SC_R_A53_0			1
> 
> You cannot change binding constants... Aren't you breaking all possible
> boards and users?

Hi Krzysztof,

There is a backward compatibility section added in the end of the patch,
it follows the same approach as in SCFW kit v1.13.0:

+/*
+ * Compatibility defines for sc_rsrc_t
+ */
+#define IMX_SC_R_A35                   IMX_SC_R_AP_2
+#define IMX_SC_R_A35_0                 IMX_SC_R_AP_2_0
+#define IMX_SC_R_A35_1                 IMX_SC_R_AP_2_1
+#define IMX_SC_R_A35_2                 IMX_SC_R_AP_2_2
+#define IMX_SC_R_A35_3                 IMX_SC_R_AP_2_3
+#define IMX_SC_R_A53                   IMX_SC_R_AP_0
+#define IMX_SC_R_A53_0                 IMX_SC_R_AP_0_0
+#define IMX_SC_R_A53_1                 IMX_SC_R_AP_0_1
+#define IMX_SC_R_A53_2                 IMX_SC_R_AP_0_2
+#define IMX_SC_R_A53_3                 IMX_SC_R_AP_0_3

Regards,
Viorel