linux-kernel - Re: [RFC PATCH 0/2] usb: typec: ucsi: Check connection on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyRUF5cFGpe2xf+m@kuha.fi.intel.com>
Date:   Fri, 16 Sep 2022 13:46:47 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Bastian Rieck <bastian@...ck.me>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        grzegorz.alibozek@...il.com, andrew.co@...e.fr, meven29@...il.com,
        pchernik@...il.com, jorge.cep.mart@...il.com,
        danielmorgan@...root.org, bernie@...ewiz.org,
        saipavanchitta1998@...il.com, rubin@...rset.net,
        maniette@...il.com, nate@....org
Subject: Re: [RFC PATCH 0/2] usb: typec: ucsi: Check connection on resume

Hi Bastian,

On Fri, Sep 09, 2022 at 09:22:50AM +0300, Heikki Krogerus wrote:
> On Thu, Sep 08, 2022 at 07:01:34AM +0200, Bastian Rieck wrote:
> > Dear Heikki,
> > 
> > > I'm sending these as an RFC first because I'm not done testing.
> > > 
> > > I made a small modification to my original proposal (in the bug
> > > report). Now also connection during suspend should be covered.
> > > 
> > > I would appreciate if you guys could test these again. If
> > > everything works, and the bug is fixed, let me know, and I'll add
> > > your Tested-by tags to the patches.
> > >
> > 
> > Thanks so much for these changes—that's awesome! I have just finished 
> > testing this against 5.19.7 (Arch Linux) with a Lenovo X1 (Gen 9).
> > 
> > I am very happy to see that, as far as I can tell, the issue 
> > disappeared completely!
> > 
> > However, I am receiving additional warnings via `journalctl` that I 
> > did not receive before; I have attached this trace as an additional 
> > log file. Nothing in there seems critical and I can confirm that the 
> > system continues to operate normally. I merely wanted to provide you 
> > with this additional information in case it is of relevance.
> > 
> > Please let me know if there's anything else I can do here; I really 
> > appreciate the time you spent on this!
> 
> Thank you for the report. That warning certainly needs to be sorted
> out before I send the final versions. I'll try to reproduce that.

I'm not getting anywhere with this one. Could you provide me with the
trace output from both module and ucsi events?

To enable those events - assuming debugfs is mounted to
/sys/kernel/debug:

        % echo 1 > /sys/kernel/debug/tracing/events/ucsi/enable
        % echo 1 > /sys/kernel/debug/tracing/events/module/enable

Run the suspend resume cycle, and then dump the trace output to a
file:

        % cat /sys/kernel/debug/tracing/trace > ucsi_trace

thanks,

-- 
heikki