linux-kernel - Re: [PATCH] serial: 8250: omap: Use serial8250_em485

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1176cc1-342f-ca4d-12a3-b237adca4ccf@linux.intel.com>
Date:   Fri, 16 Sep 2022 14:16:18 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Lukas Wunner <lukas@...ner.de>,
        Thierry Reding <treding@...dia.com>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250: omap: Use serial8250_em485_supported

On Fri, 16 Sep 2022, Matthias Schiffer wrote:

> 8250_omap uses em485, fill in rs485_supported accordingly. This makes
> RS485 work with 8250_omap again, which was broken with the introduction
> of the RS485 config sanitization.
> 
> Fixes: be2e2cb1d2819 ("serial: Sanitize rs485_struct")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> ---

Yes, good catch. I really don't know how I managed to miss it.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.

>  drivers/tty/serial/8250/8250_omap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index ff51ff91b9237..38ee3e42251af 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -1337,6 +1337,7 @@ static int omap8250_probe(struct platform_device *pdev)
>  	up.port.throttle = omap_8250_throttle;
>  	up.port.unthrottle = omap_8250_unthrottle;
>  	up.port.rs485_config = serial8250_em485_config;
> +	up.port.rs485_supported = serial8250_em485_supported;
>  	up.rs485_start_tx = serial8250_em485_start_tx;
>  	up.rs485_stop_tx = serial8250_em485_stop_tx;
>  	up.port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
>