linux-kernel - Re: [PATCH] dmaengine: qcom-adm: fix wrong sizeof config in slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <17ee7d23-27d3-4d29-aec3-a61f7d0d3526@www.fastmail.com>
Date:   Fri, 16 Sep 2022 14:20:47 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Christian Marangi" <ansuelsmth@...il.com>,
        "Andy Gross" <agross@...nel.org>,
        "Bjorn Andersson" <andersson@...nel.org>,
        "Konrad Dybcio" <konrad.dybcio@...ainline.org>,
        "Vinod Koul" <vkoul@...nel.org>, "Mark Brown" <broonie@...nel.org>,
        linux-arm-msm@...r.kernel.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org
Subject: Re: [PATCH] dmaengine: qcom-adm: fix wrong sizeof config in slave_config

On Thu, Sep 15, 2022, at 10:48 PM, Christian Marangi wrote:
> Fix broken slave_config function that uncorrectly compare the
> peripheral_size with the size of the config pointer instead of the size
> of the config struct. This cause the crci value to be ignored and cause
> a kernel panic on any slave that use adm driver.
>
> To fix this, compare to the size of the struct and NOT the size of the
> pointer.
>
> Fixes: 03de6b273805 ("dmaengine: qcom-adm: stop abusing slave_id config")
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> Cc: stable@...r.kernel.org # v5.17+

Thanks for the fix,

Reviewed-by: Arnd Bergmann <arnd@...db.de>

I guess this worked on 64-bit by accident, since both the pointer
and the struct are 8 bytes, but it was clearly wrong and broke
32-bit.

     Arnd