linux-kernel - Re: [PATCH 3/4] slimbus: qcom-ngd-ctrl: Make QMI message rules const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5b2eaa8-70eb-21b2-e2e7-485aaa927a5d@quicinc.com>
Date:   Fri, 16 Sep 2022 08:20:42 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Alex Elder <elder@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Kalle Valo <kvalo@...nel.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
CC:     <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] slimbus: qcom-ngd-ctrl: Make QMI message rules const

On 9/16/2022 6:06 AM, Srinivas Kandagatla wrote:
> 
> 
> On 13/09/2022 00:25, Jeff Johnson wrote:
>> Commit ff6d365898d ("soc: qcom: qmi: use con
> 
> SHA ID should be at least 12 chars long.
> 
> Same comment for all the patches in the series.
> 
> 
> st for struct
>> qmi_elem_info") allows QMI message encoding/decoding rules to be
>> const, so do that for qcom-ngd-ctrl.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> 
> Other than that it LGTM,
> Once fixed:
> 
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> 
> --srini

that was corrected in v2. thx for the ack