linux-kernel - [PATCH v3 2/7] acpi/x86: s2idle: If a new AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220916182609.3039-3-mario.limonciello@amd.com>
Date:   Fri, 16 Sep 2022 13:26:04 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     <rafael@...nel.org>, <linux-kernel@...r.kernel.org>
CC:     <travisghansen@...oo.com>, <catalin@...ebit.com>,
        <Shyam-sundar.S-k@....com>,
        Matthew Anderson <ruinairas1992@...il.com>,
        <philipp.zabel@...il.com>, "Sebastian S ." <iam@...entr.al>,
        Hans de Goede <hdegoede@...hat.com>,
        Mario Limonciello <mario.limonciello@....com>,
        "Len Brown" <lenb@...nel.org>, <linux-acpi@...r.kernel.org>
Subject: [PATCH v3 2/7] acpi/x86: s2idle: If a new AMD _HID is missing assume Rembrandt

A mistake was made that only AMDI0007 was set to rev of "2", but
it should have been also set for AMDI008. If an ID is missing from
the _HID table, then assume it matches Rembrandt behavior.

This implicitly means that if any other behavior changes happen
in the future missing IDs must be added to that table.

Tested-by: catalin@...ebit.com
Reviewed-by: Philipp Zabel <philipp.zabel@...il.com>
Tested-by: Philipp Zabel <philipp.zabel@...il.com> # GA402RJ
Signed-off-by: Mario Limonciello <mario.limonciello@....com>
---
v2->v3:
 * Add tags
---
 drivers/acpi/x86/s2idle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
index 28a3ef9a6bc1..2c5931d247a2 100644
--- a/drivers/acpi/x86/s2idle.c
+++ b/drivers/acpi/x86/s2idle.c
@@ -412,7 +412,7 @@ static int lps0_device_attach(struct acpi_device *adev,
 		if (dev_id)
 			data = (const struct amd_lps0_hid_device_data *) dev_id->driver_data;
 		else
-			return 0;
+			data = &amd_rembrandt;
 		rev_id = data->rev_id;
 		lps0_dsm_func_mask = validate_dsm(adev->handle,
 					ACPI_LPS0_DSM_UUID_AMD, rev_id, &lps0_dsm_guid);
-- 
2.34.1