linux-kernel - Re: [PATCH -next] nexthop: simplify code in nh_valid_get_bucket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70a79b03-c691-3376-e88c-fd742d3e41d7@wanadoo.fr>
Date:   Sat, 17 Sep 2022 18:07:20 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     williamsukatube@....com, dsahern@...nel.org, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] nexthop: simplify code in nh_valid_get_bucket_req

Le 17/09/2022 à 08:30, williamsukatube@....com a écrit :
> From: William Dean <williamsukatube@....com>
> 
> It could directly return 'nh_valid_get_bucket_req_res_bucket' to simplify code.
> 
> Signed-off-by: William Dean <williamsukatube@....com>
> ---
>   net/ipv4/nexthop.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
> index 853a75a8fbaf..1556961cf153 100644
> --- a/net/ipv4/nexthop.c
> +++ b/net/ipv4/nexthop.c
> @@ -3489,12 +3489,8 @@ static int nh_valid_get_bucket_req(const struct nlmsghdr *nlh,
>   		return -EINVAL;
>   	}
> 
> -	err = nh_valid_get_bucket_req_res_bucket(tb[NHA_RES_BUCKET],
> +	return nh_valid_get_bucket_req_res_bucket(tb[NHA_RES_BUCKET],
>   						 bucket_index, extack);

Nit: there should be 1 additional space to keep alignment.

CJ

> -	if (err)
> -		return err;
> -
> -	return 0;
>   }
> 
>   /* rtnl */