linux-kernel - Re: [linux][PATCH v9 2/2] dts: arm: at91: Add SAMA5D3-EDS Board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c1817f0-da79-7264-7fb6-31a518c3126a@linaro.org>
Date:   Sat, 17 Sep 2022 18:01:46 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jerry.Ray@...rochip.com, Claudiu.Beznea@...rochip.com,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [linux][PATCH v9 2/2] dts: arm: at91: Add SAMA5D3-EDS Board

On 13/09/2022 15:53, Jerry.Ray@...rochip.com wrote:
>>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for 
>>> evaluating many Microchip ethernet switch and PHY products.  Various 
>>> daughter cards can connect via an RGMII connector or an RMII connector.
>>>
>>> The EDS board is not intended for stand-alone use and has no ethernet 
>>> capabilities when no daughter board is connected.  As such, this 
>>> device tree is intended to be used with a DT overlay defining the add-on board.
>>> To better ensure consistency, some items are defined here as a form of 
>>> documentation so that all add-on overlays will use the same terms.
>>>
>>> Link: 
>>> https://www.microchip.com/en-us/development-tool/SAMA5D3-ETHERNET-DEVE
>>> LOPMENT-SYSTEM
>>> Signed-off-by: Jerry Ray <jerry.ray@...rochip.com>
>>> ---
>>> v8->v9:
>>>  - Changed node name from gpio to gpio-inputs
>>
>> Why not gpio-keys as all other DTSes are doing? Anyway, I can change it while applying.
>>
>> Thank you,
>> Claudiu Beznea
>>
> 
> gpio-keys is the compatible string name. I wanted the node name to be unique
> for grep purposes.

Node names should not be unique but generic.

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> 
> Regards,
> Jerry.
> 
>>> v7->v8:
>>>  - correcting patch subject line.
>>> v6->v7:

Please trim your replies... there is no need to quote everything after
the comment.

(snip)


Best regards,
Krzysztof