linux-kernel - Re: [PATCH v5 2/3] power: supply: rt9471: Add Richtek RT9471 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220916181050.7cwu36euz4hvfkem@mercury.elektranox.org>
Date:   Fri, 16 Sep 2022 20:10:50 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     cy_huang <u0084500@...il.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        mazziesaccount@...il.com, alina_yu@...htek.com,
        cy_huang@...htek.com, alinayu829@...il.com,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/3] power: supply: rt9471: Add Richtek RT9471 charger
 driver

Hi,

On Thu, Sep 15, 2022 at 12:30:14AM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@...htek.com>
> 
> Add support for the RT9471 3A 1-Cell Li+ battery charger.
> 
> The RT9471 is a highly-integrated 3A switch mode battery charger with
> low impedance power path to better optimize the charging efficiency.
> 
> Co-developed-by: Alina Yu <alina_yu@...htek.com>
> Signed-off-by: Alina Yu <alina_yu@...htek.com>
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> ---
> [...]
> +static DEVICE_ATTR_RW(sysoff_enable);
> +static DEVICE_ATTR_RW(port_detect_enable);
> +
> +static struct attribute *rt9471_sysfs_entries[] = {
> +	&dev_attr_sysoff_enable.attr,
> +	&dev_attr_port_detect_enable.attr,
> +	NULL
> +};
> +
> +static const struct attribute_group rt9471_attr_group = {
> +	.attrs	= rt9471_sysfs_entries,
> +};
> +
> +static const struct attribute_group *rt9471_attr_groups[] = {
> +	&rt9471_attr_group,
> +	NULL
> +};

Iff these custom properties are required (see response to the last
patch), then 'ATTRIBUTE_GROUPS()' can be used to simplify this part
a bit.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)