| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202209170705.iboWVVE6-lkp@intel.com>
Date: Sat, 17 Sep 2022 08:06:02 +0800
From: kernel test robot <lkp@...el.com>
To: Moshe Tal <moshet@...dia.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
Tariq Toukan <tariqt@...dia.com>
Subject: drivers/net/ethernet/mellanox/mlx5/core/en_main.c:3466:12: warning:
stack frame size (1068) exceeds limit (1024) in 'mlx5e_setup_tc'
Hi Moshe,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a335366bad1364a07f49df9da1fdfa6d411a5f39
commit: 0bb7228f7096d760252eb6948e2858376d628062 net/mlx5e: Fix mqprio_rl handling on devlink reload
date: 8 weeks ago
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220917/202209170705.iboWVVE6-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0bb7228f7096d760252eb6948e2858376d628062
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 0bb7228f7096d760252eb6948e2858376d628062
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/ net/netfilter/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:3466:12: warning: stack frame size (1068) exceeds limit (1024) in 'mlx5e_setup_tc' [-Wframe-larger-than]
static int mlx5e_setup_tc(struct net_device *dev, enum tc_setup_type type,
^
1 warning generated.
vim +/mlx5e_setup_tc +3466 drivers/net/ethernet/mellanox/mlx5/core/en_main.c
955bcb6ea0df0d Pablo Neira Ayuso 2019-07-09 3465
9afe9a53537789 Or Gerlitz 2018-01-01 @3466 static int mlx5e_setup_tc(struct net_device *dev, enum tc_setup_type type,
de4784ca030fed Jiri Pirko 2017-08-07 3467 void *type_data)
0cf0f6d3d39672 Jiri Pirko 2017-08-07 3468 {
4e95bc268b915c Pablo Neira Ayuso 2019-07-09 3469 struct mlx5e_priv *priv = netdev_priv(dev);
2ff349c5edfe3e Roi Dayan 2020-09-16 3470 bool tc_unbind = false;
214baf22870cfa Maxim Mikityanskiy 2021-01-19 3471 int err;
4e95bc268b915c Pablo Neira Ayuso 2019-07-09 3472
2ff349c5edfe3e Roi Dayan 2020-09-16 3473 if (type == TC_SETUP_BLOCK &&
2ff349c5edfe3e Roi Dayan 2020-09-16 3474 ((struct flow_block_offload *)type_data)->command == FLOW_BLOCK_UNBIND)
2ff349c5edfe3e Roi Dayan 2020-09-16 3475 tc_unbind = true;
2ff349c5edfe3e Roi Dayan 2020-09-16 3476
2ff349c5edfe3e Roi Dayan 2020-09-16 3477 if (!netif_device_present(dev) && !tc_unbind)
2ff349c5edfe3e Roi Dayan 2020-09-16 3478 return -ENODEV;
2ff349c5edfe3e Roi Dayan 2020-09-16 3479
0cf0f6d3d39672 Jiri Pirko 2017-08-07 3480 switch (type) {
daa664a5cdd599 Vlad Buslov 2019-08-29 3481 case TC_SETUP_BLOCK: {
daa664a5cdd599 Vlad Buslov 2019-08-29 3482 struct flow_block_offload *f = type_data;
daa664a5cdd599 Vlad Buslov 2019-08-29 3483
c9f14470d04830 Vlad Buslov 2019-08-26 3484 f->unlocked_driver_cb = true;
955bcb6ea0df0d Pablo Neira Ayuso 2019-07-09 3485 return flow_block_cb_setup_simple(type_data,
955bcb6ea0df0d Pablo Neira Ayuso 2019-07-09 3486 &mlx5e_block_cb_list,
4e95bc268b915c Pablo Neira Ayuso 2019-07-09 3487 mlx5e_setup_tc_block_cb,
4e95bc268b915c Pablo Neira Ayuso 2019-07-09 3488 priv, priv, true);
daa664a5cdd599 Vlad Buslov 2019-08-29 3489 }
575ed7d39e2fbe Nogah Frankel 2017-11-06 3490 case TC_SETUP_QDISC_MQPRIO:
e2aeac448f06ac Tariq Toukan 2021-07-06 3491 mutex_lock(&priv->state_lock);
e2aeac448f06ac Tariq Toukan 2021-07-06 3492 err = mlx5e_setup_tc_mqprio(priv, type_data);
e2aeac448f06ac Tariq Toukan 2021-07-06 3493 mutex_unlock(&priv->state_lock);
e2aeac448f06ac Tariq Toukan 2021-07-06 3494 return err;
214baf22870cfa Maxim Mikityanskiy 2021-01-19 3495 case TC_SETUP_QDISC_HTB:
214baf22870cfa Maxim Mikityanskiy 2021-01-19 3496 mutex_lock(&priv->state_lock);
214baf22870cfa Maxim Mikityanskiy 2021-01-19 3497 err = mlx5e_setup_tc_htb(priv, type_data);
214baf22870cfa Maxim Mikityanskiy 2021-01-19 3498 mutex_unlock(&priv->state_lock);
214baf22870cfa Maxim Mikityanskiy 2021-01-19 3499 return err;
0cf0f6d3d39672 Jiri Pirko 2017-08-07 3500 default:
0cf0f6d3d39672 Jiri Pirko 2017-08-07 3501 return -EOPNOTSUPP;
0cf0f6d3d39672 Jiri Pirko 2017-08-07 3502 }
08fb1dacdd7634 Saeed Mahameed 2016-02-22 3503 }
08fb1dacdd7634 Saeed Mahameed 2016-02-22 3504
:::::: The code at line 3466 was first introduced by commit
:::::: 9afe9a5353778994d4396f3d5ff639221bfa5cc9 net/mlx5e: Eliminate build warnings on no previous prototype
:::::: TO: Or Gerlitz <ogerlitz@...lanox.com>
:::::: CC: Saeed Mahameed <saeedm@...lanox.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists