linux-kernel - Re: [PATCH] iommu/iova: using separate rcache for SAC and DAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202209171115.TzR7T0b4-lkp@intel.com>
Date:   Sat, 17 Sep 2022 11:44:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     "brookxu.cn" <brookxu.cn@...il.com>, robin.murphy@....com,
        joro@...tes.org, will@...nel.org
Cc:     kbuild-all@...ts.01.org, iommu@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/iova: using separate rcache for SAC and DAC

Hi brookxu.cn",

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v6.0-rc5]
[also build test ERROR on linus/master next-20220916]
[cannot apply to joro-iommu/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/brookxu-cn/iommu-iova-using-separate-rcache-for-SAC-and-DAC/20220916-234845
base:    80e78fcce86de0288793a0ef0f6acf37656ee4cf
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20220917/202209171115.TzR7T0b4-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/fa50a31c6b74157cac20cd44b3717c19b934ff76
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review brookxu-cn/iommu-iova-using-separate-rcache-for-SAC-and-DAC/20220916-234845
        git checkout fa50a31c6b74157cac20cd44b3717c19b934ff76
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/iommu/iova.c: In function 'iova_rcache_get':
>> drivers/iommu/iova.c:902:24: error: expected ';' before '}' token
     902 |         return iova_pfn
         |                        ^
         |                        ;
     903 | }
         | ~                       


vim +902 drivers/iommu/iova.c

   878	
   879	/*
   880	 * Try to satisfy IOVA allocation range from rcache.  Fail if requested
   881	 * size is too big or the DMA limit we are given isn't satisfied by the
   882	 * top element in the magazine.
   883	 */
   884	static unsigned long iova_rcache_get(struct iova_domain *iovad,
   885					     unsigned long size,
   886					     unsigned long limit_pfn)
   887	{
   888		unsigned int log_size = order_base_2(size);
   889		unsigned long iova_pfn;
   890		unsigned int index;
   891	
   892		if (log_size >= IOVA_RANGE_CACHE_MAX_SIZE || !iovad->rcaches)
   893			return 0;
   894	
   895		iova_pfn = __iova_rcache_get(&iovad->rcaches[log_size], limit_pfn - size);
   896	
   897		if (!iova_pfn && limit_pfn > DMA_BIT_MASK(32)) {
   898			index = log_size + IOVA_RANGE_CACHE_MAX_SIZE;
   899			iova_pfn = __iova_rcache_get(&iovad->rcaches[index], limit_pfn - size);
   900		}
   901	
 > 902		return iova_pfn
   903	}
   904	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp