| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202209181907.xalxTddt-lkp@intel.com>
Date: Sun, 18 Sep 2022 19:19:24 +0800
From: kernel test robot <lkp@...el.com>
To: Jens Axboe <axboe@...nel.dk>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Jason A. Donenfeld" <zx2c4@...nel.org>
Subject: [linux-stable-rc:linux-4.19.y 3113/3874] drivers/char/random.c:1336:
Error: unrecognized opcode `csrs sstatus,s7'
Hi Jens,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
head: d4263a0749d603ef83c9e887841af68149e87a5a
commit: 1923d9a8a08684c063da049fa9d5d8139edbbcbb [3113/3874] random: convert to using fops->write_iter()
config: riscv-randconfig-r042-20220916
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=1923d9a8a08684c063da049fa9d5d8139edbbcbb
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.19.y
git checkout 1923d9a8a08684c063da049fa9d5d8139edbbcbb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/ lib//
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
418 | #define static_branch_likely(x) likely(static_key_enabled(&(x)->key))
| ^~~~~~
drivers/char/random.c:83:23: note: in expansion of macro 'static_branch_likely'
83 | #define crng_ready() (static_branch_likely(&crng_is_ready) || crng_init >= CRNG_READY)
| ^~~~~~~~~~~~~~~~~~~~
drivers/char/random.c:1363:22: note: in expansion of macro 'crng_ready'
1363 | if (!crng_ready())
| ^~~~~~~~~~
include/linux/compiler.h:61:31: warning: ignoring attribute 'section ("_ftrace_branch")' because it conflicts with previous 'section ("_ftrace_annotated_branch")' [-Wattributes]
61 | static struct ftrace_branch_data \
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler.h:58:49: note: in definition of macro '__trace_if'
58 | if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
| ^~~~
drivers/char/random.c:1363:17: note: in expansion of macro 'if'
1363 | if (!crng_ready())
| ^~
include/linux/compiler.h:45:26: note: in expansion of macro '__branch_check__'
45 | # define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
include/linux/jump_label.h:418:41: note: in expansion of macro 'likely'
418 | #define static_branch_likely(x) likely(static_key_enabled(&(x)->key))
| ^~~~~~
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
56 | #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
| ^~~~~~~~~~
include/linux/jump_label.h:327:9: note: in expansion of macro 'if'
327 | if (!__builtin_types_compatible_p(typeof(*x), struct static_key) && \
| ^~
include/linux/jump_label.h:418:48: note: in expansion of macro 'static_key_enabled'
418 | #define static_branch_likely(x) likely(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~~~~~
drivers/char/random.c:83:23: note: in expansion of macro 'static_branch_likely'
83 | #define crng_ready() (static_branch_likely(&crng_is_ready) || crng_init >= CRNG_READY)
| ^~~~~~~~~~~~~~~~~~~~
drivers/char/random.c:1363:22: note: in expansion of macro 'crng_ready'
1363 | if (!crng_ready())
| ^~~~~~~~~~
include/linux/compiler.h:28:33: note: previous declaration here
28 | ______f = { \
| ^~~~~~~
include/linux/compiler.h:58:49: note: in definition of macro '__trace_if'
58 | if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
| ^~~~
drivers/char/random.c:1363:17: note: in expansion of macro 'if'
1363 | if (!crng_ready())
| ^~
include/linux/compiler.h:45:26: note: in expansion of macro '__branch_check__'
45 | # define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
include/linux/jump_label.h:418:41: note: in expansion of macro 'likely'
418 | #define static_branch_likely(x) likely(static_key_enabled(&(x)->key))
| ^~~~~~
drivers/char/random.c:83:23: note: in expansion of macro 'static_branch_likely'
83 | #define crng_ready() (static_branch_likely(&crng_is_ready) || crng_init >= CRNG_READY)
| ^~~~~~~~~~~~~~~~~~~~
drivers/char/random.c:1363:22: note: in expansion of macro 'crng_ready'
1363 | if (!crng_ready())
| ^~~~~~~~~~
include/linux/compiler.h:25:39: warning: ignoring attribute 'section ("_ftrace_annotated_branch")' because it conflicts with previous 'section ("_ftrace_branch")' [-Wattributes]
25 | static struct ftrace_likely_data \
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler.h:69:30: note: in definition of macro '__trace_if'
69 | ______r = !!(cond); \
| ^~~~
drivers/char/random.c:1363:17: note: in expansion of macro 'if'
1363 | if (!crng_ready())
| ^~
include/linux/compiler.h:45:26: note: in expansion of macro '__branch_check__'
45 | # define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
include/linux/jump_label.h:418:41: note: in expansion of macro 'likely'
418 | #define static_branch_likely(x) likely(static_key_enabled(&(x)->key))
| ^~~~~~
drivers/char/random.c:83:23: note: in expansion of macro 'static_branch_likely'
83 | #define crng_ready() (static_branch_likely(&crng_is_ready) || crng_init >= CRNG_READY)
| ^~~~~~~~~~~~~~~~~~~~
drivers/char/random.c:1363:22: note: in expansion of macro 'crng_ready'
1363 | if (!crng_ready())
| ^~~~~~~~~~
include/linux/compiler.h:64:25: note: previous declaration here
64 | ______f = { \
| ^~~~~~~
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
56 | #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
| ^~~~~~~~~~
drivers/char/random.c:1363:17: note: in expansion of macro 'if'
1363 | if (!crng_ready())
| ^~
arch/riscv/include/asm/irqflags.h: Assembler messages:
arch/riscv/include/asm/irqflags.h:36: Error: unrecognized opcode `csrc sstatus,2'
arch/riscv/include/asm/irqflags.h:30: Error: unrecognized opcode `csrs sstatus,2'
arch/riscv/include/asm/irqflags.h:30: Error: unrecognized opcode `csrs sstatus,2'
arch/riscv/include/asm/irqflags.h:42: Error: unrecognized opcode `csrrc s7,sstatus,2'
arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,0'
arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,s7'
drivers/char/random.c:1316: Error: unrecognized opcode `csrs sstatus,a3'
drivers/char/random.c:1316: Error: unrecognized opcode `csrc sstatus,a3'
drivers/char/random.c:1322: Error: unrecognized opcode `csrs sstatus,a4'
drivers/char/random.c:1322: Error: unrecognized opcode `csrc sstatus,a4'
>> drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s7'
>> drivers/char/random.c:1336: Error: unrecognized opcode `csrc sstatus,s7'
drivers/char/random.c:1340: Error: unrecognized opcode `csrs sstatus,s7'
drivers/char/random.c:1340: Error: unrecognized opcode `csrc sstatus,s7'
arch/riscv/include/asm/irqflags.h:42: Error: unrecognized opcode `csrrc s2,sstatus,2'
arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,0'
arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,s2'
arch/riscv/include/asm/irqflags.h:42: Error: unrecognized opcode `csrrc s2,sstatus,2'
arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,0'
arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,s2'
vim +1336 drivers/char/random.c
0d35cc7b3fec62 Jason A. Donenfeld 2022-02-11 1307
43ae4860ff4a35 Matt Mackall 2008-04-29 1308 static long random_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1309 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1310 int __user *p = (int __user *)arg;
1923d9a8a08684 Jens Axboe 2022-05-19 1311 int ent_count;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1312
^1da177e4c3f41 Linus Torvalds 2005-04-16 1313 switch (cmd) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1314 case RNDGETENTCNT:
0d35cc7b3fec62 Jason A. Donenfeld 2022-02-11 1315 /* Inherently racy, no point locking. */
85b46e0c80a637 Jason A. Donenfeld 2022-04-30 1316 if (put_user(input_pool.init_bits, p))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1317 return -EFAULT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1318 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1319 case RNDADDTOENTCNT:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1320 if (!capable(CAP_SYS_ADMIN))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1321 return -EPERM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1322 if (get_user(ent_count, p))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1323 return -EFAULT;
cead215ea9fdb5 Jason A. Donenfeld 2022-02-04 1324 if (ent_count < 0)
cead215ea9fdb5 Jason A. Donenfeld 2022-02-04 1325 return -EINVAL;
85b46e0c80a637 Jason A. Donenfeld 2022-04-30 1326 credit_init_bits(ent_count);
cead215ea9fdb5 Jason A. Donenfeld 2022-02-04 1327 return 0;
1923d9a8a08684 Jens Axboe 2022-05-19 1328 case RNDADDENTROPY: {
1923d9a8a08684 Jens Axboe 2022-05-19 1329 struct iov_iter iter;
1923d9a8a08684 Jens Axboe 2022-05-19 1330 struct iovec iov;
1923d9a8a08684 Jens Axboe 2022-05-19 1331 ssize_t ret;
1923d9a8a08684 Jens Axboe 2022-05-19 1332 int len;
1923d9a8a08684 Jens Axboe 2022-05-19 1333
^1da177e4c3f41 Linus Torvalds 2005-04-16 1334 if (!capable(CAP_SYS_ADMIN))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1335 return -EPERM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 @1336 if (get_user(ent_count, p++))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1337 return -EFAULT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1338 if (ent_count < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1339 return -EINVAL;
1923d9a8a08684 Jens Axboe 2022-05-19 1340 if (get_user(len, p++))
1923d9a8a08684 Jens Axboe 2022-05-19 1341 return -EFAULT;
1923d9a8a08684 Jens Axboe 2022-05-19 1342 ret = import_single_range(WRITE, p, len, &iov, &iter);
1923d9a8a08684 Jens Axboe 2022-05-19 1343 if (unlikely(ret))
1923d9a8a08684 Jens Axboe 2022-05-19 1344 return ret;
1923d9a8a08684 Jens Axboe 2022-05-19 1345 ret = write_pool(&iter);
1923d9a8a08684 Jens Axboe 2022-05-19 1346 if (unlikely(ret < 0))
1923d9a8a08684 Jens Axboe 2022-05-19 1347 return ret;
1923d9a8a08684 Jens Axboe 2022-05-19 1348 /* Since we're crediting, enforce that it was all written into the pool. */
1923d9a8a08684 Jens Axboe 2022-05-19 1349 if (unlikely(ret != len))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1350 return -EFAULT;
85b46e0c80a637 Jason A. Donenfeld 2022-04-30 1351 credit_init_bits(ent_count);
cead215ea9fdb5 Jason A. Donenfeld 2022-02-04 1352 return 0;
1923d9a8a08684 Jens Axboe 2022-05-19 1353 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1354 case RNDZAPENTCNT:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1355 case RNDCLEARPOOL:
85b46e0c80a637 Jason A. Donenfeld 2022-04-30 1356 /* No longer has any effect. */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1357 if (!capable(CAP_SYS_ADMIN))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1358 return -EPERM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1359 return 0;
d848e5f8e1ebdb Theodore Ts'o 2018-04-11 1360 case RNDRESEEDCRNG:
d848e5f8e1ebdb Theodore Ts'o 2018-04-11 1361 if (!capable(CAP_SYS_ADMIN))
d848e5f8e1ebdb Theodore Ts'o 2018-04-11 1362 return -EPERM;
13ffd431ae1032 Jason A. Donenfeld 2022-03-08 1363 if (!crng_ready())
d848e5f8e1ebdb Theodore Ts'o 2018-04-11 1364 return -ENODATA;
e2fc165d51e9e3 Jason A. Donenfeld 2022-02-08 1365 crng_reseed();
d848e5f8e1ebdb Theodore Ts'o 2018-04-11 1366 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1367 default:
^1da177e4c3f41 Linus Torvalds 2005-04-16 1368 return -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1369 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1370 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1371
:::::: The code at line 1336 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (83394 bytes)
Powered by blists - more mailing lists