linux-kernel - Re: [PATCH] of: base: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 18 Sep 2022 21:03:46 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Jilin Yuan <yuanjilin@...rlc.com>
Cc:     robh+dt@...nel.org, frowand.list@...il.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: base: fix repeated words in comments

On Sun, Sep 18, 2022 at 05:59:57PM +0800, Jilin Yuan wrote:
>  /**
>   * of_match_node - Tell if a device_node has a matching of_match structure
> - * @matches:	array of of device match structures to search in
> + * @matches:	array of device match structures to search in
>   * @node:	the of device structure to match against
>   *
>   * Low level utility function used by device matching.
> @@ -1175,7 +1175,7 @@ EXPORT_SYMBOL(of_match_node);
>   *		you pass will not be searched, only the next one
>   *		will; typically, you pass what the previous call
>   *		returned. of_node_put() will be called on it
> - * @matches:	array of of device match structures to search in
> + * @matches:	array of device match structures to search in
>   * @match:	Updated to point at the matches entry which matched

That second "of" is the device, so the fix doesn't make sense.

Also, PLEASE stop sending these mindless redundant word-stripping patches
as byproduct of whatever automated tool you use.

As Edward Cree said to one of your colleague [1]:

> #ifdef RANT
> NGL, getting kinda sick of these bogus comment text 'fixes' from people
>  who clearly don't have enough mastery of English to copyedit it.
> (Previous one from this author was actually wrong too but I didn't catch
>  it at the time.)
> English is a tricksy language, why would someone with a limited
>  understanding of it think that grammar fixes are the best use of their
>  time and energy?
> I can't help suspecting that this is a box-ticking exercise, where a
>  certain corporate culture has a standard requirement that engineers
>  must get X number of Linux / opensource commits in order to get
>  promoted, and this kind of mindless patch is the easiest way for them
>  to achieve that.
> #endif

If you really want to do real cleanup, consider joining kernel-janitors list.

Learn from above, thanks.

[1]: https://lore.kernel.org/netdev/30f2488d-9af3-fe8d-6e6f-713a7d38800b@gmail.com/

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)