linux-kernel - Re: [v7 13/14] iio: imu: add BNO055 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220918182626.00aae26d@jic23-huawei>
Date:   Sun, 18 Sep 2022 18:26:26 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andrea Merello <andrea.merello@...il.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Andrea Merello <andrea.merello@....it>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        jmondi <jacopo@...ndi.org>, Bagas Sanjaya <bagasdotme@...il.com>
Subject: Re: [v7 13/14] iio: imu: add BNO055 I2C driver

On Thu, 8 Sep 2022 08:42:01 +0200
Andrea Merello <andrea.merello@...il.com> wrote:

> > Hmm... It has my tag but I have noticed something to improve.  
> 
> One comment below, OK for the rest.
> 
> > ...
> >  
> > > +#define BNO055_I2C_XFER_BURST_BREAK_THRESHOLD 3 /* FIXME */  
> >
> > Can we elaborate what to fix and why it can't be fixed right now?  
> 
> Ah, this is a stale comment; I'll drop it..

I fixed up Andy's comments on this patch whilst applying.

Thanks,

Jonathan