linux-kernel - Re: [PATCH] mm/damon: return void from damon_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6843CCD1-F6F3-40AA-9A5C-7DFD65475864@linux.dev>
Date:   Sun, 18 Sep 2022 10:36:39 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     xiakaixu1987@...il.com
Cc:     sj@...nel.org, Andrew Morton <akpm@...ux-foundation.org>,
        damon@...ts.linux.dev, Linux MM <linux-mm@...ck.org>,
        linux-kernel@...r.kernel.org, Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] mm/damon: return void from damon_set_schemes()



> On Sep 16, 2022, at 23:20, xiakaixu1987@...il.com wrote:
> 
> From: Kaixu Xia <kaixuxia@...cent.com>
> 
> There is no point in returning an int from damon_set_schemes().
> It always returns 0 which is meaningless for the caller, so
> change it to return void directly.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>

Reviewed-by: Muchun Song <songmuchun@...edance.com>

Thanks.