linux-kernel - Re: [PATCH v2 01/13] trinity: Add base driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2022 13:26:16 +0900
From:   Jiho Chu <jiho.chu@...sung.com>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        ogabbay@...nel.org,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        "Mark Brown" <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        yelini.jeong@...sung.com, myungjoo.ham@...sung.com
Subject: Re: [PATCH v2 01/13] trinity: Add base driver

On Sat, 17 Sep 2022 09:41:13 +0200
"Arnd Bergmann" <arnd@...db.de> wrote:

> 
> > +
> > +#ifndef TASK_COMM_LEN
> > +#define TASK_COMM_LEN 16
> > +#endif
> > +
> > +#define TRINITY_APP_NAME_MAX TASK_COMM_LEN
> > +#define TRINITY_APP_STAT_MAX 10
> > +#define TRINITY_REQ_STAT_MAX 10
> 
> The structure layout should not depend on whether an application
> has included a header that defines TASK_COMM_LEN.
> 
> What is the purpose of including an application name here?
> 

I agree. TASK_COMM_LEN will be removed.
app_name is current context's execuable name, and it's used for
per-app NPU statistics info.

Thanks,
Jiho Chu