linux-kernel - RE: [EXT] Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM9PR04MB87937614E6564FDBD98D3D93884D9@AM9PR04MB8793.eurprd04.prod.outlook.com>
Date:   Mon, 19 Sep 2022 17:07:26 +0000
From:   Frank Li <frank.li@....com>
To:     Bjorn Helgaas <helgaas@...nel.org>
CC:     "maz@...nel.org" <maz@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kw@...ux.com" <kw@...ux.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Peng Fan <peng.fan@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "jdmason@...zu.us" <jdmason@...zu.us>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "kishon@...com" <kishon@...com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "ntb@...ts.linux.dev" <ntb@...ts.linux.dev>,
        "lznuaa@...il.com" <lznuaa@...il.com>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
        "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>
Subject: RE: [EXT] Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c



> -----Original Message-----
> From: Bjorn Helgaas <helgaas@...nel.org>
> Sent: Monday, September 19, 2022 12:03 PM
> To: Frank Li <frank.li@....com>
> Cc: maz@...nel.org; tglx@...utronix.de; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; shawnguo@...nel.org;
> s.hauer@...gutronix.de; kw@...ux.com; bhelgaas@...gle.com; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-pci@...r.kernel.org; Peng Fan
> <peng.fan@....com>; Aisheng Dong <aisheng.dong@....com>;
> jdmason@...zu.us; kernel@...gutronix.de; festevam@...il.com; dl-linux-
> imx <linux-imx@....com>; kishon@...com; lorenzo.pieralisi@....com;
> ntb@...ts.linux.dev; lznuaa@...il.com; imx@...ts.linux.dev;
> manivannan.sadhasivam@...aro.org
> Subject: [EXT] Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c
> 
> Caution: EXT Email
> 
> In subject (I mentioned this last time, too):
> 
>   PCI: endpoint: pci-epf-vntb: Clean up
> 
> On Mon, Sep 19, 2022 at 10:40:37AM -0500, Frank Li wrote:
> > Remove unused field: epf_db_phy.
> > Remove __iomem before epf_db.
> > Change epf_db to u32* from void *
> > Remove dupicate check if (readl(ntb->epf_db + i * 4)).
> 
> s/dupicate/duplicate/
> 
> > Using sizeof(u32) instead of number 4 at all place.
> >
> > Clean up sparse build warning
> >   Using  epf_db[i] instead of readl() because epf_db is located in local
> memory
> >   and allocated by dma_alloc_coherent()
> 
> Is "Using epf_db[i] ..." an sparse warning?  The indentation suggests
> that it is, but it doesn't seem related.

[Frank Li] sparse warning about __IOMEM.  Dma_alloc_conherece()
Return void *.  Not void __IOMEM *.  

Readl() use void __IOMEM *. 

Epf_db[i] is more simple and have not memory order risk here.    

> 
> > Replace pci_epc_mem_free_addr() with pci_epf_free_space() at error
> handle path
> > to match pci_epf_alloc_space().
> >
> > Cleanup warning found by scripts/kernel-doc
> > Fix indentation of the struct epf_ntb_ctrl
> > Consildate term
> 
> s/Consildate/Consolidate/
> 
> >   host, host1 to HOST
> >   vhost, vHost, Vhost, VHOST2 to VHOST