linux-kernel - Re: [PATCH 3/3] staging: rtl8192e: spaces preferred around that '<<' (ctx:VxV)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2022 20:51:21 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Aruna Hewapathirane <aruna.hewapathirane@...il.com>,
        gregkh@...uxfoundation.org
Cc:     f3sch.git@...look.com, guozihua@...wei.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8192e: spaces preferred around that '<<'
 (ctx:VxV)

On 9/19/22 16:16, Aruna Hewapathirane wrote:
> This patch fixes 2 checkpatch CHECK issues
> 
> Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@...il.com>
> ---
>   drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> index f651947f6b44..933f347fc17e 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -818,10 +818,10 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
>   					 cpu_to_le16(rtllib_query_seqnum(ieee, skb_frag,
>   							     header.addr1));
>   				frag_hdr->seq_ctl =
> -					 cpu_to_le16(le16_to_cpu(frag_hdr->seq_ctl)<<4 | i);
> +					 cpu_to_le16(le16_to_cpu(frag_hdr->seq_ctl) << 4 | i);
>   			} else {
>   				frag_hdr->seq_ctl =
> -					 cpu_to_le16(ieee->seq_ctrl[0]<<4 | i);
> +					 cpu_to_le16(ieee->seq_ctrl[0] << 4 | i);
>   			}
>   			/* Put a SNAP header on the first fragment */
>   			if (i == 0) {


Please remove the 3/3
add a V2 and a change history