linux-kernel - Re: [PATCH 2/2] staging: rtl8192e: removes blank line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFSeFg-awEMyZjePcvO_Mo3k_pFX-Kq85Uvbub6bmA7XkQ7zZA@mail.gmail.com>
Date:   Mon, 19 Sep 2022 15:19:19 -0400
From:   Aruna Hewapathirane <aruna.hewapathirane@...il.com>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, f3sch.git@...look.com,
        guozihua@...wei.com, linux-staging@...ts.linux.dev,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] staging: rtl8192e: removes blank line

On Mon, Sep 19, 2022 at 2:41 PM Philipp Hortmann
<philipp.g.hortmann@...il.com> wrote:
>
> On 9/19/22 15:58, Aruna Hewapathirane wrote:
> > This patch fixes a checkpatch CHECK issue
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@...il.com>
> > ---
> >   drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> > index d5275319a486..f651947f6b44 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> >                                       tcb_desc->bTxDisableRateFallBack = 1;
> >                               }
> >
> > -
> >                               tcb_desc->RATRIndex = 7;
> >                               tcb_desc->bTxUseDriverAssingedRate = 1;
> >                               tcb_desc->bdhcp = 1;
>
> Please avoid the 2/2 in the subject. This is only for patch series.

I will do so in future I did not know this. My apologies.

> Create a version 2 of this patch with change history.

I have no idea how to create a version2 with a change history but I am
going to Google and see what I can find.

> Removing blank lines is OK but do this for the entire document.

Ah.. of course makes  sense. Once again my apologies.

> Add the file name to the subject to make it more unique.

I will do so. Thank you Philipp.

>
>
> Bye Philipp


On Mon, Sep 19, 2022 at 2:41 PM Philipp Hortmann
<philipp.g.hortmann@...il.com> wrote:
>
> On 9/19/22 15:58, Aruna Hewapathirane wrote:
> > This patch fixes a checkpatch CHECK issue
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@...il.com>
> > ---
> >   drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> > index d5275319a486..f651947f6b44 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> >                                       tcb_desc->bTxDisableRateFallBack = 1;
> >                               }
> >
> > -
> >                               tcb_desc->RATRIndex = 7;
> >                               tcb_desc->bTxUseDriverAssingedRate = 1;
> >                               tcb_desc->bdhcp = 1;
>
> Please avoid the 2/2 in the subject. This is only for patch series.
> Create a version 2 of this patch with change history.
> Removing blank lines is OK but do this for the entire document.
> Add the file name to the subject to make it more unique.
>
> Bye Philipp