linux-kernel - Re: [PATCH] lib: zstd: build common files separately for compress and decompress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 20 Sep 2022 05:39:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nicholas Piggin <npiggin@...il.com>, Nick Terrell <terrelln@...com>
Cc:     kbuild-all@...ts.01.org, Nicholas Piggin <npiggin@...il.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] lib: zstd: build common files separately for compress
 and decompress

Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc6 next-20220919]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nicholas-Piggin/lib-zstd-build-common-files-separately-for-compress-and-decompress/20220919-200605
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 521a547ced6477c54b4b0cc206000406c221b4d6
config: microblaze-randconfig-c043-20220918 (https://download.01.org/0day-ci/archive/20220920/202209200555.i687Ffik-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5c841e581c21f9aeb22e008899f84ac275b462a9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nicholas-Piggin/lib-zstd-build-common-files-separately-for-compress-and-decompress/20220919-200605
        git checkout 5c841e581c21f9aeb22e008899f84ac275b462a9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   microblaze-linux-ld: lib/zstd/decompress/common/debug.o:lib/zstd/decompress/common/debug.c:24: multiple definition of `g_debuglevel'; lib/zstd/compress/common/debug.o:lib/zstd/compress/common/debug.c:24: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `FSE_versionNumber':
   lib/zstd/decompress/common/entropy_common.c:27: multiple definition of `FSE_versionNumber'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/entropy_common.c:27: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `ERR_isError':
>> lib/zstd/decompress/common/error_private.h:45: multiple definition of `FSE_isError'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/error_private.h:45: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `FSE_getErrorName':
   lib/zstd/decompress/common/entropy_common.c:32: multiple definition of `FSE_getErrorName'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/entropy_common.c:32: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `ERR_isError':
>> lib/zstd/decompress/common/error_private.h:45: multiple definition of `HUF_isError'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/error_private.h:45: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `HUF_getErrorName':
   lib/zstd/decompress/common/entropy_common.c:35: multiple definition of `HUF_getErrorName'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/entropy_common.c:35: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `FSE_readNCount_bmi2':
   lib/zstd/decompress/common/entropy_common.c:226: multiple definition of `FSE_readNCount_bmi2'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/entropy_common.c:226: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `FSE_readNCount':
   lib/zstd/decompress/common/entropy_common.c:239: multiple definition of `FSE_readNCount'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/entropy_common.c:239: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `HUF_readStats':
   lib/zstd/decompress/common/entropy_common.c:254: multiple definition of `HUF_readStats'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/entropy_common.c:254: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/entropy_common.o: in function `HUF_readStats_wksp':
   lib/zstd/decompress/common/entropy_common.c:349: multiple definition of `HUF_readStats_wksp'; lib/zstd/compress/common/entropy_common.o:lib/zstd/compress/common/entropy_common.c:349: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/error_private.o: in function `ERR_getErrorString':
   lib/zstd/decompress/common/error_private.c:22: multiple definition of `ERR_getErrorString'; lib/zstd/compress/common/error_private.o:lib/zstd/compress/common/error_private.c:22: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/fse_decompress.o: in function `FSE_createDTable':
   lib/zstd/decompress/common/fse_decompress.c:64: multiple definition of `FSE_createDTable'; lib/zstd/compress/common/fse_decompress.o:lib/zstd/compress/common/fse_decompress.c:64: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/fse_decompress.o: in function `FSE_freeDTable':
   lib/zstd/decompress/common/fse_decompress.c:69: multiple definition of `FSE_freeDTable'; lib/zstd/compress/common/fse_decompress.o:lib/zstd/compress/common/fse_decompress.c:69: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/fse_decompress.o: in function `FSE_buildDTable_wksp':
   lib/zstd/decompress/common/fse_decompress.c:177: multiple definition of `FSE_buildDTable_wksp'; lib/zstd/compress/common/fse_decompress.o:lib/zstd/compress/common/fse_decompress.c:177: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/fse_decompress.o: in function `FSE_buildDTable_rle':
   lib/zstd/decompress/common/fse_decompress.c:202: multiple definition of `FSE_buildDTable_rle'; lib/zstd/compress/common/fse_decompress.o:lib/zstd/compress/common/fse_decompress.c:202: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/fse_decompress.o: in function `FSE_buildDTable_raw':
   lib/zstd/decompress/common/fse_decompress.c:211: multiple definition of `FSE_buildDTable_raw'; lib/zstd/compress/common/fse_decompress.o:lib/zstd/compress/common/fse_decompress.c:211: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/fse_decompress.o: in function `FSE_decompress_usingDTable':
   lib/zstd/decompress/common/fse_decompress.c:297: multiple definition of `FSE_decompress_usingDTable'; lib/zstd/compress/common/fse_decompress.o:lib/zstd/compress/common/fse_decompress.c:297: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/fse_decompress.o: in function `FSE_decompress_wksp':
   lib/zstd/decompress/common/fse_decompress.c:309: multiple definition of `FSE_decompress_wksp'; lib/zstd/compress/common/fse_decompress.o:lib/zstd/compress/common/fse_decompress.c:309: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/fse_decompress.o: in function `FSE_decompress_wksp_bmi2':
   lib/zstd/decompress/common/fse_decompress.c:375: multiple definition of `FSE_decompress_wksp_bmi2'; lib/zstd/compress/common/fse_decompress.o:lib/zstd/compress/common/fse_decompress.c:375: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ZSTD_versionNumber':
   lib/zstd/decompress/common/zstd_common.c:25: multiple definition of `ZSTD_versionNumber'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/zstd_common.c:25: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ZSTD_versionString':
   lib/zstd/decompress/common/zstd_common.c:27: multiple definition of `ZSTD_versionString'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/zstd_common.c:27: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ERR_isError':
>> lib/zstd/decompress/common/error_private.h:45: multiple definition of `ZSTD_isError'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/error_private.h:45: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ZSTD_getErrorName':
   lib/zstd/decompress/common/zstd_common.c:41: multiple definition of `ZSTD_getErrorName'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/zstd_common.c:41: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ERR_getErrorCode':
>> lib/zstd/decompress/common/error_private.h:47: multiple definition of `ZSTD_getErrorCode'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/error_private.h:47: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ZSTD_getErrorString':
   lib/zstd/decompress/common/zstd_common.c:49: multiple definition of `ZSTD_getErrorString'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/zstd_common.c:49: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ZSTD_customMalloc':
   lib/zstd/decompress/common/zstd_common.c:57: multiple definition of `ZSTD_customMalloc'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/zstd_common.c:57: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ZSTD_customCalloc':
   lib/zstd/decompress/common/zstd_common.c:64: multiple definition of `ZSTD_customCalloc'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/zstd_common.c:64: first defined here
   microblaze-linux-ld: lib/zstd/decompress/common/zstd_common.o: in function `ZSTD_customFree':
   lib/zstd/decompress/common/zstd_common.c:76: multiple definition of `ZSTD_customFree'; lib/zstd/compress/common/zstd_common.o:lib/zstd/compress/common/zstd_common.c:76: first defined here


vim +45 lib/zstd/decompress/common/error_private.h

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp