linux-kernel - Re: [PATCH linux-next] KVM: s390: pci: fix comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6bdfd47-7977-0d67-5e24-a8e782c93370@linux.ibm.com>
Date:   Mon, 19 Sep 2022 08:34:42 +0200
From:   Christian Borntraeger <borntraeger@...ux.ibm.com>
To:     cgel.zte@...il.com, mjrosato@...ux.ibm.com
Cc:     farman@...ux.ibm.com, frankja@...ux.ibm.com,
        imbrenda@...ux.ibm.com, david@...hat.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com, svens@...ux.ibm.com,
        linux-s390@...r.kernel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xu Panda <xu.panda@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] KVM: s390: pci: fix comparing pointer to 0

Am 18.09.22 um 16:36 schrieb cgel.zte@...il.com:
> From: Xu Panda <xu.panda@....com.cn>
> 
> Comparing pointer whith NULL instead of comparing pointer to 0.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Xu Panda <xu.panda@....com.cn>

Thanks but there is already a fix queued (https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git/commit/?h=next&id=3ed2607b18cce86efed3a3c76fce89dc11184f62)
and your fix would still trigger checkpatch --strict warning.
> ---
>   arch/s390/kvm/pci.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kvm/pci.h b/arch/s390/kvm/pci.h
> index 3a3606c3a0fe..aadafa2e03d1 100644
> --- a/arch/s390/kvm/pci.h
> +++ b/arch/s390/kvm/pci.h
> @@ -46,8 +46,8 @@ extern struct zpci_aift *aift;
>   static inline struct kvm *kvm_s390_pci_si_to_kvm(struct zpci_aift *aift,
>                                                   unsigned long si)
>   {
> -       if (!IS_ENABLED(CONFIG_VFIO_PCI_ZDEV_KVM) || aift->kzdev == 0 ||
> -           aift->kzdev[si] == 0)
> +       if (!IS_ENABLED(CONFIG_VFIO_PCI_ZDEV_KVM) || aift->kzdev == NULL ||
> +           aift->kzdev[si] == NULL)
>                  return 0;
>          return aift->kzdev[si]->kvm;
>   };