[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <99314fcf-b886-a7bd-3866-241af6ac9831@suse.de>
Date: Mon, 19 Sep 2022 08:44:19 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Hamza Mahfooz <hamza.mahfooz@....com>, linux-kernel@...r.kernel.org
Cc: Guchun Chen <guchun.chen@....com>, David Airlie <airlied@...ux.ie>,
dri-devel@...ts.freedesktop.org,
"Pan, Xinhui" <Xinhui.Pan@....com>, amd-gfx@...ts.freedesktop.org,
Aurabindo Pillai <aurabindo.pillai@....com>,
Sean Paul <seanpaul@...omium.org>,
Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
Fernando Ramos <greenfoo@....eu>
Subject: Re: [PATCH] drm/amdgpu: use dirty framebuffer helper
Hi
Am 06.09.22 um 21:57 schrieb Hamza Mahfooz:
> Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use
> drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs
> struct.
drm_atomic_helper_dirtyfb() creates a new atomic commit for the
frambuffer's planes. Drivers can then updates these planes' output
(e.g., writeback to video memory). I thought that amdgpu simply scans
out from the framebuffer's memory regions in VRAM. So I'm curious why
this patch is necessary.
Best regards
Thomas
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index c20922a5af9f..5b09c8f4fe95 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -38,6 +38,7 @@
> #include <linux/pci.h>
> #include <linux/pm_runtime.h>
> #include <drm/drm_crtc_helper.h>
> +#include <drm/drm_damage_helper.h>
> #include <drm/drm_edid.h>
> #include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_fb_helper.h>
> @@ -496,6 +497,7 @@ bool amdgpu_display_ddc_probe(struct amdgpu_connector *amdgpu_connector,
> static const struct drm_framebuffer_funcs amdgpu_fb_funcs = {
> .destroy = drm_gem_fb_destroy,
> .create_handle = drm_gem_fb_create_handle,
> + .dirty = drm_atomic_helper_dirtyfb,
> };
>
> uint32_t amdgpu_display_supported_domains(struct amdgpu_device *adev,
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)
Powered by blists - more mailing lists