linux-kernel - Re: [PATCH v1 2/3] dt-bindings: thermal: Convert ls2k to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25c6693c-a57f-8ea2-71e8-fda9646fd7f1@linaro.org>
Date:   Mon, 19 Sep 2022 09:03:17 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Yinbo Zhu <zhuyinbo@...ngson.cn>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     zhanghongchen <zhanghongchen@...ngson.cn>
Subject: Re: [PATCH v1 2/3] dt-bindings: thermal: Convert ls2k to json-schema

On 19/09/2022 05:49, Yinbo Zhu wrote:
> Convert the ls2k thermal binding to DT schema format using json-schema
> 
> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>

FYI, All your patches were marked as spam, unfortunately.

> ---
>  .../bindings/thermal/ls2k-thermal.yaml        | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml
> 
> diff --git a/Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml
> new file mode 100644
> index 000000000000..44bc5d4626d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml

Filename based on compatible.

> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/ls2k-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Thermal sensors on loongson 2k SoCs
> +
> +maintainers:
> +  - zhanghongchen <zhanghongchen@...ngson.cn>
> +  - Yinbo Zhu <zhuyinbo@...ngson.cn>
> +
> +properties:
> +  compatible:
> +    const: loongson,2k-thermal
> +
> +  reg:
> +    maxItems: 1
> +
> +  id:
> +    const: 0

Why? What is this? No description, no type (is there such standard
property?), no vendor prefix... and always equal to 0?

> +
> +  interrupt-parent:
> +    maxItems: 1

That's not needed, I think.

> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - id
> +  - interrupt-parent
> +  - interrupts
> +  - '#thermal-sensor-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    tsensor: tsensor@...01500 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Use names used by other examples.

> +        compatible = "loongson,2k-tsensor";
> +        reg = <0 0x1fe01500 0 0x30>;
> +        id = <0>;
> +        interrupt-parent = <&icu>;
> +        interrupts = <7>;
> +        #thermal-sensor-cells = <1>;
> +    };


Best regards,
Krzysztof