linux-kernel - Re: [PATCH 0/6] staging: rtl8192e: Remove ftrace-like logging RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YygVsmIFlt4IQ/E4@kadam>
Date:   Mon, 19 Sep 2022 10:09:38 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] staging: rtl8192e: Remove ftrace-like logging
 RT_TRACE

On Sat, Sep 17, 2022 at 06:24:53AM +0200, Philipp Hortmann wrote:
> Remove "Unnecessary ftrace-like logging" as requested by checkpatch. To
> keep the logging would make future patches for fixing CamelCase larger.
> 
> Tested with rtl8192e
> Transferred this patch over wlan connection of rtl8192e
> 

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

When I'm reviewing a mass delete change like this, the typical bug that
I'm looking for is deleting extra lines by mistake.  So I go through it
line by line and make sure nothing extra was deleted.  It's not
complicated but it just takes a while to check.

This patchset will introduce some checkpatch warnings about extra
curly braces but I actually prefer if those are fixed in a separate
patch.  It makes these easier to review.  If you were just deleting
one RT_TRACE() call then doing it together is the correct thing but when
it's a mass delete I prefer the curly braces changes done as a separate
thing.

regards,
dan carpenter