linux-kernel - Re: [PATCH -next] scsi: qla2xxx: Fix build error implicit-function-declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220919071721.upsccdkhzp3zanui@carbon.lan>
Date:   Mon, 19 Sep 2022 09:17:21 +0200
From:   Daniel Wagner <dwagner@...e.de>
To:     Ren Zhijie <renzhijie2@...wei.com>
Cc:     njavali@...vell.com, GR-QLogic-Storage-Upstream@...vell.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com, aeasi@...vell.com,
        himanshu.madhani@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] scsi: qla2xxx: Fix build error
 implicit-function-declaration

On Mon, Sep 19, 2022 at 11:08:10AM +0800, Ren Zhijie wrote:
> +#ifdef CONFIG_TRACING
>  static void
>  qla_trace_init(void)
>  {
> @@ -2868,7 +2871,7 @@ qla_trace_uninit(void)
>  		return;
>  	trace_array_put(qla_trc_array);
>  }
> -
> +#endif

FWIW, the qla2xxx driver uses a different pattern for ifdefs

	static void
	qla_trace_init(void)
	{
	#ifdef CONFIG_TRACING
	[...]
        #endif
        }

This avoid to updated the callside with ifdefs.