linux-kernel - Re: [PATCH v1 3/3] thermal: ls2k: add thermal management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2022 16:58:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yinbo Zhu <zhuyinbo@...ngson.cn>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        zhanghongchen <zhanghongchen@...ngson.cn>,
        Yinbo Zhu <zhuyinbo@...ngson.cn>
Subject: Re: [PATCH v1 3/3] thermal: ls2k: add thermal management support

Hi Yinbo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v6.0-rc6 next-20220916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yinbo-Zhu/MAINTAINERS-add-maintainer-for-thermal-driver-for-ls2k-SoCs/20220919-115133
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: arm-randconfig-r014-20220919
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/69249e17ad2ac5f9bc14b77f8bdef440e011a7d9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Yinbo-Zhu/MAINTAINERS-add-maintainer-for-thermal-driver-for-ls2k-SoCs/20220919-115133
        git checkout 69249e17ad2ac5f9bc14b77f8bdef440e011a7d9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/thermal/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/thermal/ls2k_thermal.c:185:5: warning: no previous prototype for function 'ls2k_thermal_remove' [-Wmissing-prototypes]
   int ls2k_thermal_remove(struct platform_device *pdev)
       ^
   drivers/thermal/ls2k_thermal.c:185:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int ls2k_thermal_remove(struct platform_device *pdev)
   ^
   static 
   1 warning generated.


vim +/ls2k_thermal_remove +185 drivers/thermal/ls2k_thermal.c

   184	
 > 185	int ls2k_thermal_remove(struct platform_device *pdev)
   186	{
   187		struct ls2k_thermal_data *data = platform_get_drvdata(pdev);
   188		int reg_off = data->id * 2;
   189	
   190		/* disable interrupt */
   191		writew(0, data->regs + LS2K_TSENSOR_CTRL_LO + reg_off);
   192		writew(0, data->regs + LS2K_TSENSOR_CTRL_HI + reg_off);
   193	
   194		return 0;
   195	}
   196	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (144759 bytes)