linux-kernel - Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <076b1f2a38ab4ca4a61e6a79c765bcba@huawei.com>
Date:   Mon, 19 Sep 2022 09:01:38 +0000
From:   zhaogongyi <zhaogongyi@...wei.com>
To:     David Hildenbrand <david@...hat.com>,
        Akinobu Mita <akinobu.mita@...il.com>
CC:     "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "Jonathan Corbet" <corbet@....net>,
        "osalvador@...e.de" <osalvador@...e.de>,
        "shuah@...nel.org" <shuah@...nel.org>
Subject: Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working
 usage of negative values

Hi!

> 
> On 17.09.22 07:39, Akinobu Mita wrote:
> > 2022年9月15日(木) 18:01 Zhao Gongyi <zhaogongyi@...wei.com>:
> >>
> >> Fault injection uses debugfs in a way that the provided values via
> >> sysfs are interpreted as u64. Providing negative numbers results in
> >> an error:
> >>
> >>    # cd sys/kernel/debug/notifier-error-inject/memory
> >>    #  echo -12 > actions/MEM_GOING_ONLINE/error
> >>    -bash: echo: write error: Invalid argument
> >>
> >> Update the docs and examples to use "printf %#x <val>" in these cases.
> >
> > I'd rather fix the notifier-error-inject module than change the user
> interface.
> > I'll send a patch, so could you check if that solves the problem.
> >
> 
> That will also make patch #2 unnecessary, correct?

Yes. But there is another commit 005747526d4f3c2ec995891e95cb7625161022f9 that has the same problem.

Thanks!

> 
> --
> Thanks,
> 
> David / dhildenb