linux-kernel - Re: [PATCH] media: dt-bindings: i2c: ovti,ov5640: Drop ref to video-interface-devices.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2022 10:35:21 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Ripard <maxime@...no.tech>,
        Steve Longerbeam <slongerbeam@...il.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] media: dt-bindings: i2c: ovti,ov5640: Drop ref to video-interface-devices.yaml

Hi Krzysztof,

On Mon, Sep 19, 2022 at 9:19 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 19/09/2022 10:08, Lad, Prabhakar wrote:
> > Hi Laurent,
> >
> > Thank you for the review.
> >
> > On Sun, Sep 18, 2022 at 12:06 AM Laurent Pinchart
> > <laurent.pinchart@...asonboard.com> wrote:
> >>
> >> Hi Prabhakar,
> >>
> >> Thank you for the patch.
> >>
> >> On Fri, Sep 16, 2022 at 02:35:21PM +0100, Prabhakar wrote:
> >>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >>>
> >>> video-interface-devices.yaml isn't used so just drop it from the
> >>> DT binding doc.
> >>>
> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml | 3 ---
> >>>  1 file changed, 3 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> >>> index 540fd69ac39f..ce99aada75ad 100644
> >>> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> >>> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> >>> @@ -9,9 +9,6 @@ title: OmniVision OV5640 Image Sensor Device Tree Bindings
> >>>  maintainers:
> >>>    - Steve Longerbeam <slongerbeam@...il.com>
> >>>
> >>> -allOf:
> >>> -  - $ref: /schemas/media/video-interface-devices.yaml#
> >>> -
> >>
> >> The rotation property listed in this binding uses the definition from
> >> video-interface-devices.yaml. I don't think just dropping this is the
> >> right solution. Changing additionaProperties to unevaluatedProperties
> >> seems a better option.
> >>
> > Agreed, I missed rotation was used from video-interface-devices.yaml.
> > Agreed the changing additionaProperties to unevaluatedProperties seems
> > a better option.
>
> The meaning of unevaluatedProperties:false would be here - accept other
> properties (not mentioned here explicitly) from referenced schema. If
> this is your actual intention for this binding, it makes sense. But if
> the intention in this binding was to disallow these other properties,
> then it would be wrong to change to unevaluatedProperties.
>
Thank you for the clarification. The intention is to disallow the property.

> Therefore before sending patches and calling something better or not,
> please instead focus on that aspect of referenced schema.
>
Sure will do, sorry for the noise.

Cheers,
Prabhakar