linux-kernel - Re: [PATCH -next] cgroup: simplify code in cgroup_apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22ef7722-2f60-688d-4cf0-f59f0272a293@quicinc.com>
Date:   Mon, 19 Sep 2022 16:19:10 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     <williamsukatube@....com>, <tj@...nel.org>,
        <lizefan.x@...edance.com>, <hannes@...xchg.org>,
        <cgroups@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] cgroup: simplify code in cgroup_apply_control

Hi,

On 9/17/2022 2:10 PM, williamsukatube@....com wrote:
> From: William Dean <williamsukatube@....com>
> 
> It could directly return 'cgroup_update_dfl_csses' to simplify code.
> 
> Signed-off-by: William Dean <williamsukatube@....com>
> ---
>   kernel/cgroup/cgroup.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index e4bb5d57f4d1..1958f8bd93d6 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -3292,11 +3292,7 @@ static int cgroup_apply_control(struct cgroup *cgrp)
>   	 * making the following cgroup_update_dfl_csses() properly update
>   	 * css associations of all tasks in the subtree.
>   	 */
> -	ret = cgroup_update_dfl_csses(cgrp);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return cgroup_update_dfl_csses(cgrp);
>   }
> 
>   /**
> --
> 2.25.1
> 

LGTM.

Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh