linux-kernel - Re: [PATCH v2 08/16] mm/page_alloc: add missing is_migrate_isolate() check in set_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27ac1a9c-5f44-a25c-aa09-844debbb88f8@redhat.com>
Date:   Mon, 19 Sep 2022 13:28:58 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org,
        osalvador@...e.de, anshuman.khandual@....com
Cc:     willy@...radead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 08/16] mm/page_alloc: add missing is_migrate_isolate()
 check in set_page_guard()

On 16.09.22 09:22, Miaohe Lin wrote:
> In MIGRATE_ISOLATE case, zone freepage state shouldn't be modified as
> caller will take care of it. Add missing is_migrate_isolate() here to
> avoid possible unbalanced freepage state. This would happen if someone
> isolates the block, and then we face an MCE failure/soft-offline on a
> page within that block. __mod_zone_freepage_state() will be triggered
> via below call trace which already had been triggered back when block
> was isolated:
> 
> take_page_off_buddy
>    break_down_buddy_pages
>      set_page_guard
> 
> Fixes: 06be6ff3d2ec ("mm,hwpoison: rework soft offline for free pages")
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> Reviewed-by: Oscar Salvador <osalvador@...e.de>
> ---

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb