| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <YyhlQPhezmLG8ZCn@pendragon.ideasonboard.com>
Date: Mon, 19 Sep 2022 15:49:04 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Marco Felsch <m.felsch@...gutronix.de>, mchehab@...nel.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
kishon@...com, vkoul@...nel.org, hverkuil@...all.nl,
jacopo@...ndi.org, kieran.bingham+renesas@...asonboard.com,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
kernel@...gutronix.de
Subject: Re: [PATCH v2 4/4] media: tc358746: add Toshiba TC358746 Parallel to
CSI-2 bridge driver
On Mon, Sep 19, 2022 at 12:39:35PM +0000, Sakari Ailus wrote:
> Hi Marco,
>
> Looks good, a few comments below...
>
> On Fri, Sep 16, 2022 at 03:45:35PM +0200, Marco Felsch wrote:
> > Adding support for the TC358746 parallel <-> MIPI CSI bridge. This chip
> > supports two operating modes:
> > 1st) parallel-in -> mipi-csi out
> > 2nd) mipi-csi in -> parallel out
> >
> > This patch only adds the support for the 1st mode.
> >
> > Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
> > ---
> > Changelog:
> >
> > v2:
> > - use the correct CID_LINK_FREQ control to query the sensor_pclk_rate
> > - remove now not needed tc358746_link_setup() and
> > struct v4l2_ctrl sensor_pclk_ctrl
> > - call v4l2_subdev_link_validate_default() during link validation
> > - remove MEDIA_BUS_FMT_GBR888_1X24/YUV444 format support
> > - use subdev active_state API
> > - replace own .get_fmt with v4l2_subdev_get_fmt
> > - remove unnecessary pad checks
> > - restructure tc358746_get_format_by_code() if-case
> > - move apply_dphy_config|apply_misc_config from resume intos s_stream
> > - use goto in s_stream enable case
> > - fix error handling in suspend/resume
> > - split probe() into more sub-functions
> > - use dev_dbg() for printing successful probe
> >
> > drivers/media/i2c/Kconfig | 17 +
> > drivers/media/i2c/Makefile | 1 +
> > drivers/media/i2c/tc358746.c | 1682 ++++++++++++++++++++++++++++++++++
> > 3 files changed, 1700 insertions(+)
> > create mode 100644 drivers/media/i2c/tc358746.c
[snip]
> > diff --git a/drivers/media/i2c/tc358746.c b/drivers/media/i2c/tc358746.c
> > new file mode 100644
> > index 000000000000..4f1a809b9fc3
> > --- /dev/null
> > +++ b/drivers/media/i2c/tc358746.c
[snip]
> > +static int tc358746_probe(struct i2c_client *client)
> > +{
> > + struct device *dev = &client->dev;
> > + struct tc358746 *tc358746;
> > + unsigned long refclk;
> > + unsigned int i;
> > + int err;
> > +
> > + tc358746 = devm_kzalloc(&client->dev, sizeof(*tc358746), GFP_KERNEL);
> > + if (!tc358746)
> > + return -ENOMEM;
> > +
> > + tc358746->regmap = devm_regmap_init_i2c(client, &tc358746_regmap_config);
> > + if (IS_ERR(tc358746->regmap))
> > + return dev_err_probe(dev, PTR_ERR(tc358746->regmap),
> > + "Failed to init regmap\n");
> > +
> > + tc358746->refclk = devm_clk_get(dev, "refclk");
> > + if (IS_ERR(tc358746->refclk))
> > + return dev_err_probe(dev, PTR_ERR(tc358746->refclk),
> > + "Failed to get refclk\n");
> > +
> > + err = clk_prepare_enable(tc358746->refclk);
> > + if (err)
> > + return dev_err_probe(dev, err,
> > + "Failed to enable refclk\n");
> > +
> > + refclk = clk_get_rate(tc358746->refclk);
> > + clk_disable_unprepare(tc358746->refclk);
> > +
> > + if (refclk < 6 * MHZ || refclk > 40 * MHZ)
> > + return dev_err_probe(dev, -EINVAL, "Invalid refclk range\n");
> > +
> > + for (i = 0; i < ARRAY_SIZE(tc358746_supplies); i++)
> > + tc358746->supplies[i].supply = tc358746_supplies[i];
> > +
> > + err = devm_regulator_bulk_get(dev, ARRAY_SIZE(tc358746_supplies),
> > + tc358746->supplies);
> > + if (err)
> > + return dev_err_probe(dev, err, "Failed to get supplies\n");
> > +
> > + tc358746->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> > + GPIOD_OUT_HIGH);
> > + if (IS_ERR(tc358746->reset_gpio))
> > + return dev_err_probe(dev, PTR_ERR(tc358746->reset_gpio),
> > + "Failed to get reset-gpios\n");
> > +
> > + err = tc358746_init_subdev(tc358746, client);
> > + if (err)
> > + return dev_err_probe(dev, err, "Failed to init subdev\n");
> > +
> > + err = tc358746_init_output_port(tc358746, refclk);
> > + if (err)
> > + goto err_subdev;
> > +
> > + /*
> > + * Keep this order since we need the output port link-frequencies
> > + * information.
> > + */
> > + err = tc358746_init_controls(tc358746);
> > + if (err)
> > + goto err_fwnode;
> > +
> > + dev_set_drvdata(dev, tc358746);
> > + pm_runtime_set_autosuspend_delay(dev, 200);
> > + pm_runtime_use_autosuspend(dev);
> > + pm_runtime_enable(dev);
> > +
> > + err = tc358746_init_hw(tc358746);
>
> The driver depends on runtime PM being enabled but does not depend on
> CONFIG_PM. I'd suggest to power the device on and only then enable runtime
> PM. See
> <URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html#power-management>.
Or simply depend on CONFIG_PM :-)
> > + if (err)
> > + goto err_pm;
> > +
> > + err = tc358746_setup_mclk_provider(tc358746);
> > + if (err)
> > + goto err_pm;
> > +
> > + err = tc358746_async_register(tc358746);
> > + if (err < 0)
> > + goto err_pm;
> > +
> > + dev_dbg(dev, "%s found @ 0x%x (%s)\n", client->name,
> > + client->addr, client->adapter->name);
> > +
> > + return 0;
> > +
> > +err_pm:
> > + pm_runtime_disable(dev);
> > + pm_runtime_set_suspended(dev);
> > + pm_runtime_dont_use_autosuspend(dev);
> > + v4l2_ctrl_handler_free(&tc358746->ctrl_hdl);
> > +err_fwnode:
> > + v4l2_fwnode_endpoint_free(&tc358746->csi_vep);
> > +err_subdev:
> > + v4l2_subdev_cleanup(&tc358746->sd);
> > + media_entity_cleanup(&tc358746->sd.entity);
> > +
> > + return err;
> > +}
[snip]
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists